Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2949883002: [Payment Request] null checks _webState instance before calling a method on. (Closed)

Created:
3 years, 6 months ago by Moe
Modified:
3 years, 6 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] null checks _webState instance before calling a method on. BUG=734442 Review-Url: https://codereview.chromium.org/2949883002 Cr-Commit-Position: refs/heads/master@{#480935} Committed: https://chromium.googlesource.com/chromium/src/+/73261883b7768a0e48e0c8fcfdeaf16ccb3a35ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/ui/payments/payment_request_manager.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Moe
Hi Mathieu, Please take a look.
3 years, 6 months ago (2017-06-20 19:19:15 UTC) #4
Mathieu
lgtm
3 years, 6 months ago (2017-06-20 19:25:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949883002/1
3 years, 6 months ago (2017-06-20 20:05:01 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:26:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73261883b7768a0e48e0c8fcfdea...

Powered by Google App Engine
This is Rietveld 408576698