Move ObjectContentType entirely to HTMLPlugInElement

Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.


BUG=

Review-Url: https://codereview.chromium.org/2949873005
Cr-Commit-Position: refs/heads/master@{#481217}
Committed: https://chromium.googlesource.com/chromium/src/+/f12fc43363084c86d32bf151fe94f2994a9df8c8

[Nate Chapin, 2017-06-20 19:50:54]

Description was changed from

==========
Move ObjectContentType entirely to HTMLPlugInElement

BUG=
==========

to

==========
Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.


BUG=
==========

[Nate Chapin, 2017-06-20 19:51:07]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 19:51:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2017-06-20 21:14:01]

japhet@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, schenney@chromium.org

[Nate Chapin, 2017-06-20 21:14:01]

schenney: PTAL (again)
rdevlin.cronin: FYI

This is an unmodified reland of https://codereview.chromium.org/2927703003/,
which was revert on suspicion of breaking
virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html.
I don't think it was responsible for the test failure for three reasons:
1. There's no obvious relationship between a plugin refactor and a media
controls test.
2. The test was flaky before and after revert (I was able to get it to flake
post-revert locally).
3. The trybots didn't show the break.

I'll happily re-revert if the tests breaks on second landing.

[Devlin, 2017-06-20 21:23:20]

rdevlin.cronin@chromium.org changed reviewers:
- rdevlin.cronin@chromium.org

[Devlin, 2017-06-20 21:23:44]

me -> cc.  I'm fine with this as long as tests are happy. :)

[commit-bot: I haz the power, 2017-06-20 22:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 23:00:00]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2017-06-21 13:19:05]

LGTM. I agree with the analysis.

[Nate Chapin, 2017-06-21 16:12:03]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2017-06-21 16:12:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 16:16:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498061523736450, "parent_rev":
"54b956cfa0755b0e4777d1e422e3e560c00c6f92", "commit_rev":
"f12fc43363084c86d32bf151fe94f2994a9df8c8"}

[commit-bot: I haz the power, 2017-06-21 16:16:41]

Description was changed from

==========
Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.


BUG=
==========

to

==========
Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.


BUG=

Review-Url: https://codereview.chromium.org/2949873005
Cr-Commit-Position: refs/heads/master@{#481217}
Committed:
https://chromium.googlesource.com/chromium/src/+/f12fc43363084c86d32bf151fe94...
==========

[commit-bot: I haz the power, 2017-06-21 16:16:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f12fc43363084c86d32bf151fe94...