Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2949873003: MD Settings: add 'preserve-focus' flag to fix iron-list focus bugs. (Closed)

Created:
3 years, 6 months ago by scottchen
Modified:
3 years, 5 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add 'preserve-focus' flag to fix iron-list focus bugs. This is a follow-up CL to a previous CL to patch iron-list (2794173002), in order to fix the issue of focus being lost after removing items. BUG=699001 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2949873003 Cr-Commit-Position: refs/heads/master@{#482051} Committed: https://chromium.googlesource.com/chromium/src/+/20547cb0499f83a89e55c1cc222fffe4eac89a70

Patch Set 1 #

Patch Set 2 : fingerprint list doesn't need preserve-focus since arrow-button navigation not supported anyway #

Patch Set 3 : remove debug code #

Messages

Total messages: 10 (6 generated)
scottchen
3 years, 6 months ago (2017-06-20 21:53:43 UTC) #3
hcarmona
LGTM
3 years, 5 months ago (2017-06-23 20:57:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949873003/40001
3 years, 5 months ago (2017-06-23 21:06:39 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-23 22:32:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/20547cb0499f83a89e55c1cc222f...

Powered by Google App Engine
This is Rietveld 408576698