Migrate AddToHomescreenDataFetcher to use TaskScheduler.

Migrate AddToHomescreenDataFetcher to use TaskScheduler.

BUG=667892
Review-Url: https://codereview.chromium.org/2949863003
Cr-Commit-Position: refs/heads/master@{#481359}
Committed: https://chromium.googlesource.com/chromium/src/+/231133023782d1a38e961046edfddd15bf4ec332

[dominickn, 2017-06-21 03:16:38]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 03:16:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-06-21 04:27:35]

dominickn@chromium.org changed reviewers:
+ fdoray@chromium.org

[dominickn, 2017-06-21 04:27:36]

Please sanity check, thanks!

[commit-bot: I haz the power, 2017-06-21 04:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 04:56:19]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-06-21 12:37:15]

On 2017/06/21 04:27:36, dominickn wrote:
> Please sanity check, thanks!

lgtm

The comments that explain how you chose TaskTraits are great.

If your tasks don't access data that could be destroyed during shutdown, you
could change SKIP_ON_SHUTDOWN to CONTINUE_ON_SHUTDOWN
https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h?l=59

[dominickn, 2017-06-21 23:40:40]

On 2017/06/21 12:37:15, fdoray wrote:
> On 2017/06/21 04:27:36, dominickn wrote:
> > Please sanity check, thanks!
> 
> lgtm
> 
> The comments that explain how you chose TaskTraits are great.
> 
> If your tasks don't access data that could be destroyed during shutdown, you
> could change SKIP_ON_SHUTDOWN to CONTINUE_ON_SHUTDOWN
> https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h?l=59

Thanks! I don't think it makes sense to continue icon processing on shutdown
because the user still has to confirm adding the site to homescreen icon
processing. If we're shutting down we shouldn't block on that.

[dominickn, 2017-06-21 23:40:44]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-21 23:40:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 23:46:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498088444734690, "parent_rev":
"b80ffde89677d5d2b83ca25c221a768fa0029a9b", "commit_rev":
"231133023782d1a38e961046edfddd15bf4ec332"}

[commit-bot: I haz the power, 2017-06-21 23:46:57]

Description was changed from

==========
Migrate AddToHomescreenDataFetcher to use TaskScheduler.

BUG=667892
==========

to

==========
Migrate AddToHomescreenDataFetcher to use TaskScheduler.

BUG=667892

Review-Url: https://codereview.chromium.org/2949863003
Cr-Commit-Position: refs/heads/master@{#481359}
Committed:
https://chromium.googlesource.com/chromium/src/+/231133023782d1a38e961046edfd...
==========

[commit-bot: I haz the power, 2017-06-21 23:46:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/231133023782d1a38e961046edfd...