Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 2949853002: Rename is_same_page to is_same_document in NavigationHandle. (Closed)

Created:
3 years, 6 months ago by Charlie Reis
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, nasko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename is_same_page to is_same_document in NavigationHandle. BUG=695189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2949853002 Cr-Commit-Position: refs/heads/master@{#480985} Committed: https://chromium.googlesource.com/chromium/src/+/e7bc65f60b9532f252d975c93782f5b94a5aaf64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M content/browser/frame_host/interstitial_page_navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 6 chunks +12 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/navigation_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/navigation_handle.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Charlie Reis
Eugene, can you take a look? (I ran across these while looking into some related ...
3 years, 6 months ago (2017-06-20 20:34:23 UTC) #7
Eugene But (OOO till 7-30)
Thank you! I did not grep is_same_page yet. Only SamePage and is_in_page were cleaned up. ...
3 years, 6 months ago (2017-06-20 22:00:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949853002/1
3 years, 6 months ago (2017-06-20 22:07:48 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 22:13:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7bc65f60b9532f252d975c93782...

Powered by Google App Engine
This is Rietveld 408576698