third_party/WebKit/Source/core/page/ValidationMessageClient.h - Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ValidationMessageClient.h

Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)

Patch Set: Remove now unnecessary call from WebContentsImpl::RenderViewTerminated to delegate_->HideValidation… Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/ValidationMessageClient.h

diff --git a/third_party/WebKit/Source/core/page/ValidationMessageClient.h b/third_party/WebKit/Source/core/page/ValidationMessageClient.h

index 396f4b56b401244bfedb91a72d4f6fc3f46edd21..667f9271770a68b79ae296f20b2a216f5dd48fee 100644

--- a/third_party/WebKit/Source/core/page/ValidationMessageClient.h

+++ b/third_party/WebKit/Source/core/page/ValidationMessageClient.h

@@ -32,7 +32,6 @@

namespace blink {

-class Document;

class Element;

class ValidationMessageClient : public GarbageCollectedMixin {

@@ -56,9 +55,6 @@ class ValidationMessageClient : public GarbageCollectedMixin {

// is visible.

virtual bool IsValidationMessageVisible(const Element& anchor) = 0;

- virtual void WillUnloadDocument(const Document&) = 0;

- virtual void DocumentDetached(const Document&) = 0;

virtual void WillBeDestroyed() = 0;

DEFINE_INLINE_VIRTUAL_TRACE() {}