third_party/WebKit/Source/core/page/Page.cpp - Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)

Patch Set: Remove now unnecessary call from WebContentsImpl::RenderViewTerminated to delegate_->HideValidation… Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index 4a083020409fba2b7999b1c52cfb1bf00e5c6589..38312cd3c29afc2b7f6c141751959ee6839aef00 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -253,16 +253,9 @@ void Page::SetMainFrame(Frame* main_frame) {

main_frame_ = main_frame;

}

-void Page::WillUnloadDocument(const Document& document) {

- if (validation_message_client_)

- validation_message_client_->WillUnloadDocument(document);

void Page::DocumentDetached(Document* document) {

pointer_lock_controller_->DocumentDetached(document);

context_menu_controller_->DocumentDetached(document);

- if (validation_message_client_)

- validation_message_client_->DocumentDetached(*document);

hosts_using_features_.DocumentDetached(*document);

}