Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2949593002: Add a note to the documentation on assuming your CL not is the culprit. (Closed)

Created:
3 years, 6 months ago by sullivan
Modified:
3 years, 6 months ago
Reviewers:
benry, picksi, benhenry, picksi1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a note to the documentation on assuming your CL not is the culprit. TBR=simonhatch@chromium.org Review-Url: https://codereview.chromium.org/2949593002 Cr-Commit-Position: refs/heads/master@{#480829} Committed: https://chromium.googlesource.com/chromium/src/+/563b224fd523488849591714eee28335340081a6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M docs/speed/addressing_performance_regressions.md View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
sullivan
https://codereview.chromium.org/2949593002/diff/1/docs/speed/addressing_performance_regressions.md File docs/speed/addressing_performance_regressions.md (right): https://codereview.chromium.org/2949593002/diff/1/docs/speed/addressing_performance_regressions.md#newcode121 docs/speed/addressing_performance_regressions.md:121: *** promo This "promo" block is a gitiles markdown ...
3 years, 6 months ago (2017-06-19 16:56:23 UTC) #2
benhenry
lgtm
3 years, 6 months ago (2017-06-19 17:11:54 UTC) #4
picksi
lgtm
3 years, 6 months ago (2017-06-20 13:46:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949593002/1
3 years, 6 months ago (2017-06-20 15:20:33 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-20 15:20:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949593002/1
3 years, 6 months ago (2017-06-20 15:22:40 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 15:35:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/563b224fd523488849591714eee2...

Powered by Google App Engine
This is Rietveld 408576698