Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2949583002: [Payment Request] window.PaymentRequest must be undefined if PR is disabled (Closed)

Created:
3 years, 6 months ago by Moe
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] window.PaymentRequest must be undefined if PR is disabled BUG=734586, 602666 Review-Url: https://codereview.chromium.org/2949583002 Cr-Commit-Position: refs/heads/master@{#480578} Committed: https://chromium.googlesource.com/chromium/src/+/3c7d91dbad5abcb55c58b37637522aa4e2a56bc1

Patch Set 1 #

Patch Set 2 : Fixed build dependencies #

Total comments: 2

Patch Set 3 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M ios/chrome/browser/web/BUILD.gn View 1 2 chunks +11 lines, -1 line 0 comments Download
M ios/chrome/browser/web/chrome_web_client.mm View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M ios/chrome/browser/web/chrome_web_client_unittest.mm View 3 chunks +25 lines, -3 lines 0 comments Download
M ios/chrome/browser/web/resources/chrome_bundle.js View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/resources/payment_request.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Moe
Hi Mathieu, Please take a look.
3 years, 6 months ago (2017-06-19 14:23:02 UTC) #4
Mathieu
Thanks, this lgtm as a short term fix to be merged back.
3 years, 6 months ago (2017-06-19 14:38:55 UTC) #7
Moe
Hi Eugene, Please take a look. This needs to be merged back into M60.
3 years, 6 months ago (2017-06-19 14:50:30 UTC) #11
Eugene But (OOO till 7-30)
Thanks for the test! lgtm https://codereview.chromium.org/2949583002/diff/20001/ios/chrome/browser/web/chrome_web_client.mm File ios/chrome/browser/web/chrome_web_client.mm (right): https://codereview.chromium.org/2949583002/diff/20001/ios/chrome/browser/web/chrome_web_client.mm#newcode166 ios/chrome/browser/web/chrome_web_client.mm:166: NSString* chromePageScript = GetPageScript(@"chrome_bundle"); ...
3 years, 6 months ago (2017-06-19 14:53:59 UTC) #12
Moe
Thank you. https://codereview.chromium.org/2949583002/diff/20001/ios/chrome/browser/web/chrome_web_client.mm File ios/chrome/browser/web/chrome_web_client.mm (right): https://codereview.chromium.org/2949583002/diff/20001/ios/chrome/browser/web/chrome_web_client.mm#newcode166 ios/chrome/browser/web/chrome_web_client.mm:166: NSString* chromePageScript = GetPageScript(@"chrome_bundle"); On 2017/06/19 at ...
3 years, 6 months ago (2017-06-19 15:11:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949583002/40001
3 years, 6 months ago (2017-06-19 15:11:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/482218)
3 years, 6 months ago (2017-06-19 16:23:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949583002/40001
3 years, 6 months ago (2017-06-19 21:01:28 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 21:07:46 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c7d91dbad5abcb55c58b3763752...

Powered by Google App Engine
This is Rietveld 408576698