Move the files related to Android<->Web credentials to a separate folder.

Move the files related to Android<->Web credentials to a separate folder.

The files create confusion with separate site<->site affiliation.

BUG=630555
TBR=stevenjb@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2949573002
Cr-Commit-Position: refs/heads/master@{#480510}
Committed: https://chromium.googlesource.com/chromium/src/+/e25bf805da2599005af63f8bffb990cf8a693bee

[vasilii, 2017-06-19 13:35:09]

vasilii@chromium.org changed reviewers:
+ engedy@chromium.org, vabr@chromium.org

[vasilii, 2017-06-19 13:35:11]

Hi guys,

please review the CL.

[vasilii, 2017-06-19 14:09:18]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 14:09:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 14:25:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 14:25:58]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[vabr (Chromium), 2017-06-19 15:42:04]

lgtm

[engedy, 2017-06-19 16:22:16]

LGTM % comments.

https://codereview.chromium.org/2949573002/diff/20001/components/password_man...
File
components/password_manager/core/browser/android_affiliation/affiliation_utils.h
(right):

https://codereview.chromium.org/2949573002/diff/20001/components/password_man...
components/password_manager/core/browser/android_affiliation/affiliation_utils.h:5:
// This file contains utilities related to working with "facets".
Just checking: This file is not strictly specific to Android, are you not
planning to use it for Web-Web affiliations?

https://codereview.chromium.org/2949573002/diff/20001/components/password_man...
components/password_manager/core/browser/android_affiliation/affiliation_utils.h:47:
#include <cstddef>
nit: The style guide says both this and stddef.h are okay. We are not using
std::size_t and friends either (the only difference), and the latter is much
more common in Chromium code. What is the reason for changing this?

[vasilii, 2017-06-19 17:08:37]

https://codereview.chromium.org/2949573002/diff/20001/components/password_man...
File
components/password_manager/core/browser/android_affiliation/affiliation_utils.h
(right):

https://codereview.chromium.org/2949573002/diff/20001/components/password_man...
components/password_manager/core/browser/android_affiliation/affiliation_utils.h:5:
// This file contains utilities related to working with "facets".
On 2017/06/19 16:22:16, engedy wrote:
> Just checking: This file is not strictly specific to Android, are you not
> planning to use it for Web-Web affiliations?

I see. While I definitely may need something like IsValidAndroidFacetURI(), I
think the file is tailored towards Android affiliation. Using FacetURI would be
confusing because I handle only the URLs.

https://codereview.chromium.org/2949573002/diff/20001/components/password_man...
components/password_manager/core/browser/android_affiliation/affiliation_utils.h:47:
#include <cstddef>
On 2017/06/19 16:22:16, engedy wrote:
> nit: The style guide says both this and stddef.h are okay. We are not using
> std::size_t and friends either (the only difference), and the latter is much
> more common in Chromium code. What is the reason for changing this?

The reason to touch the line was the complain from the format tool. "stddef.h"
is deprecated in the C++ standard for a long time while "cstddef" isn't.

[vasilii, 2017-06-19 17:09:57]

Description was changed from

==========
Move the files related to Android<->Web credentials to a separate folder.

The files create confusion with separate site<->site affiliation.

BUG=630555
==========

to

==========
Move the files related to Android<->Web credentials to a separate folder.

The files create confusion with separate site<->site affiliation.

BUG=630555
TBR=stevenjb@chromium.org,sdefresne@chromium.org
==========

[vasilii, 2017-06-19 17:10:53]

TBR owners of ios/chrome/browser/ui/settings/ and
chrome/browser/extensions/api/passwords_private/

[vasilii, 2017-06-19 17:11:03]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-06-19 17:11:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 18:30:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497892263802830,
"parent_rev": "141ae1f5ba2d5491fadcedbe51d82b1293bcce95", "commit_rev":
"eab94b18695cf5402de891118a03eca9db0e531c"}

[commit-bot: I haz the power, 2017-06-19 18:30:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497892263802830,
"parent_rev": "34309956ae5a711ae2e1006fe4f5a6dea34bcfc4", "commit_rev":
"e25bf805da2599005af63f8bffb990cf8a693bee"}

[commit-bot: I haz the power, 2017-06-19 18:30:59]

Description was changed from

==========
Move the files related to Android<->Web credentials to a separate folder.

The files create confusion with separate site<->site affiliation.

BUG=630555
TBR=stevenjb@chromium.org,sdefresne@chromium.org
==========

to

==========
Move the files related to Android<->Web credentials to a separate folder.

The files create confusion with separate site<->site affiliation.

BUG=630555
TBR=stevenjb@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2949573002
Cr-Commit-Position: refs/heads/master@{#480510}
Committed:
https://chromium.googlesource.com/chromium/src/+/e25bf805da2599005af63f8bffb9...
==========

[commit-bot: I haz the power, 2017-06-19 18:31:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e25bf805da2599005af63f8bffb9...

[findit-for-me, 2017-06-19 18:46:46]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2947683002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit (https://goo.gl/kROfz5) identified CL at revision 480510 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....