Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2949533003: Revert "Proper sequencing of _asyncStackTraceHelper in Kernel" (Closed)

Created:
3 years, 6 months ago by Kevin Millikin (Google)
Modified:
3 years, 6 months ago
Reviewers:
sivachandra
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Proper sequencing of _asyncStackTraceHelper in Kernel" This reverts commit 0489249d29131ed7bf047485c74f557d88eb9974. The change causes failures in the front end tests. BUG= R=sivachandra@google.com Committed: https://github.com/dart-lang/sdk/commit/8340cfda55d077312748ca2a72961871b6d1a78b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M pkg/kernel/lib/core_types.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/kernel/lib/transformations/continuation.dart View 6 chunks +0 lines, -15 lines 0 comments Download
M runtime/lib/stacktrace.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/service_kernel.status View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
sivachandra
lgtm
3 years, 6 months ago (2017-06-19 15:21:06 UTC) #2
sivachandra
lgtm
3 years, 6 months ago (2017-06-19 15:21:07 UTC) #4
Kevin Millikin (Google)
3 years, 6 months ago (2017-06-19 15:21:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8340cfda55d077312748ca2a72961871b6d1a78b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698