Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: runtime/lib/stacktrace.cc

Issue 2949533003: Revert "Proper sequencing of _asyncStackTraceHelper in Kernel" (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "lib/stacktrace.h" 5 #include "lib/stacktrace.h"
6 #include "vm/bootstrap_natives.h" 6 #include "vm/bootstrap_natives.h"
7 #include "vm/debugger.h" 7 #include "vm/debugger.h"
8 #include "vm/exceptions.h" 8 #include "vm/exceptions.h"
9 #include "vm/native_entry.h" 9 #include "vm/native_entry.h"
10 #include "vm/object_store.h" 10 #include "vm/object_store.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 return CurrentStackTrace(thread, false, 0); 104 return CurrentStackTrace(thread, false, 0);
105 } 105 }
106 106
107 107
108 DEFINE_NATIVE_ENTRY(StackTrace_current, 0) { 108 DEFINE_NATIVE_ENTRY(StackTrace_current, 0) {
109 return CurrentStackTrace(thread, false); 109 return CurrentStackTrace(thread, false);
110 } 110 }
111 111
112 112
113 DEFINE_NATIVE_ENTRY(StackTrace_asyncStackTraceHelper, 1) { 113 DEFINE_NATIVE_ENTRY(StackTrace_asyncStackTraceHelper, 1) {
114 if (!FLAG_causal_async_stacks) return Object::null();
115
116 GET_NATIVE_ARGUMENT(Closure, async_op, arguments->NativeArgAt(0)); 114 GET_NATIVE_ARGUMENT(Closure, async_op, arguments->NativeArgAt(0));
117 if (FLAG_support_debugger) { 115 if (!async_op.IsNull()) {
118 Debugger* debugger = isolate->debugger(); 116 if (FLAG_support_debugger) {
119 if (debugger != NULL) { 117 Debugger* debugger = isolate->debugger();
120 debugger->MaybeAsyncStepInto(async_op); 118 if (debugger != NULL) {
119 debugger->MaybeAsyncStepInto(async_op);
120 }
121 } 121 }
122 } 122 }
123 return CurrentStackTrace(thread, true); 123 return CurrentStackTrace(thread, true);
124 } 124 }
125 125
126 126
127 DEFINE_NATIVE_ENTRY(StackTrace_clearAsyncThreadStackTrace, 0) { 127 DEFINE_NATIVE_ENTRY(StackTrace_clearAsyncThreadStackTrace, 0) {
128 thread->clear_async_stack_trace(); 128 thread->clear_async_stack_trace();
129 return Object::null(); 129 return Object::null();
130 } 130 }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 Thread::Current(), 199 Thread::Current(),
200 StackFrameIterator::kNoCrossThreadIteration); 200 StackFrameIterator::kNoCrossThreadIteration);
201 StackFrame* frame = frames.NextFrame(); 201 StackFrame* frame = frames.NextFrame();
202 while (frame != NULL) { 202 while (frame != NULL) {
203 OS::PrintErr("%s\n", frame->ToCString()); 203 OS::PrintErr("%s\n", frame->ToCString());
204 frame = frames.NextFrame(); 204 frame = frames.NextFrame();
205 } 205 }
206 } 206 }
207 207
208 } // namespace dart 208 } // namespace dart
OLDNEW
« no previous file with comments | « pkg/kernel/lib/transformations/continuation.dart ('k') | runtime/observatory/tests/service/service_kernel.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698