[kernel] Check type for list literals

[kernel] Check type for list literals

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/c64955758486cc3c99e78e94eae26ddcbb942faf

[jensj, 2017-06-19 07:59:26]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2017-06-19 15:01:17]

LGTM with comments addressed.

https://codereview.chromium.org/2949493002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/2949493002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5702: AbstractType& list_type =
AbstractType::Handle(type_arguments.TypeAt(0));
Pass the zone argument Z so we don't have to get it from thread-local storage.

I think we could make this a ZoneHandle and change the constructor for
AbstractTypeInstr to ASSERT it gets a ZoneHandle and use the one that's passed
to it instead of creating a new one.  The way it's done now seems strange.

[jensj, 2017-06-20 10:43:31]

https://codereview.chromium.org/2949493002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/2949493002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5702: AbstractType& list_type =
AbstractType::Handle(type_arguments.TypeAt(0));
On 2017/06/19 15:01:17, Kevin Millikin (Google) wrote:
> Pass the zone argument Z so we don't have to get it from thread-local storage.
> 
> I think we could make this a ZoneHandle [...]
Done.

> and change the constructor for
> AbstractTypeInstr to ASSERT it gets a ZoneHandle and use the one that's passed
> to it instead of creating a new one.  The way it's done now seems strange.

I'll put that on my todo list for another cl.

[jensj, 2017-06-20 11:04:15]

Description was changed from

==========
[kernel] Check type for list literals

BUG=
==========

to

==========
[kernel] Check type for list literals

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c64955758486cc3c99e78e94eae26ddcbb942faf
==========

[jensj, 2017-06-20 11:04:17]

Committed patchset #2 (id:20001) manually as
c64955758486cc3c99e78e94eae26ddcbb942faf (presubmit successful).