[kernel] Check type for list literals

runtime/vm/kernel_binary_flowgraph.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_binary_flowgraph.h"
 
 #include "vm/compiler.h"
 #include "vm/longjump.h"
 #include "vm/object_store.h"
 
@@ skipping 5678 matching lines @@
   intptr_t length = ReadListLength();  // read list length.
   // Note: there will be "length" expressions.
 
   // The type argument for the factory call.
   Fragment instructions = TranslateInstantiatedTypeArguments(type_arguments);
   instructions += PushArgument();
   if (length == 0) {
     instructions += Constant(Object::empty_array());
   } else {
     // The type arguments for CreateArray.
-    instructions += Constant(TypeArguments::ZoneHandle(Z));
+    instructions += Constant(type_arguments);
     instructions += IntConstant(length);
     instructions += CreateArray();
+    AbstractType& list_type = AbstractType::Handle(type_arguments.TypeAt(0));

[Kevin Millikin (Google), 2017/06/19 15:01:17]

Pass the zone argument Z so we don't have to get it from thread-local storage.

I think we could make this a ZoneHandle and change the constructor for
AbstractTypeInstr to ASSERT it gets a ZoneHandle and use the one that's passed
to it instead of creating a new one.  The way it's done now seems strange.

[jensj, 2017/06/20 10:43:30]

Done.
I'll put that on my todo list for another cl.

 
     LocalVariable* array = MakeTemporary();
     for (intptr_t i = 0; i < length; ++i) {
       instructions += LoadLocal(array);
       instructions += IntConstant(i);
       instructions += BuildExpression();  // read ith expression.
+      instructions += CheckAssignableInCheckedMode(
+          list_type, Symbols::ListLiteralElement());
       instructions += StoreIndexed(kArrayCid);
       instructions += Drop();
     }
   }
   instructions += PushArgument();  // The array.
 
   const dart::Class& factory_class =
       dart::Class::Handle(Z, dart::Library::LookupCoreClass(Symbols::List()));
   const Function& factory_method = Function::ZoneHandle(
       Z, factory_class.LookupFactory(
@@ skipping 1418 matching lines @@
     metadata_values.SetAt(i, value);
   }
 
   return metadata_values.raw();
 }
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)