Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2949433002: Changes to metrics logging on translate UI in Android. (Closed)

Created:
3 years, 6 months ago by ramyasharma
Modified:
3 years, 6 months ago
Reviewers:
dominickn
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Changes to metrics logging on translate UI in Android. Based on discussions with the PM, following changes are being made: 1) Rename "Tab language clicked" to "Translation accepted by clicking on tab language". 2) Make sure that when a language is picked from more languages, it's logged in the Translate.CompactInfobar.Event histogram as "Translation accepted by clicking on language in more languages" 3) Rename "Translate services declined" to "X is clicked without a prior translation and without a choice of never translate" 4) Always translate clicked, Never translate clicked, Never translate site clicked, Undo always translate - update all 4 to end in "in the options menu" 5) Always translate snackbar impression, Never translate snackbar impression, Never translate site snackbar impression, Cancel clicked on always translate snackbar, Cancel clicked on never translate this site snackbar, Cancel clicked on never translate snackbar - update all 6 to end in "when triggered from the options menu" 6) "Infobar closed" get rid off 7) Rename description "Translate.InfobarShown" to indicate it's for the old UI 8) Add logic for translate declined (this was removed in another cl by mistake). BUG=720231 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2938453004 Cr-Original-Commit-Position: refs/heads/master@{#479306} Review-Url: https://codereview.chromium.org/2949433002 Cr-Commit-Position: refs/branch-heads/3112@{#378} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/21618e7dc6ce5148fd09bdb6abb3f6191a70ad63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java View 10 chunks +13 lines, -4 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +29 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ramyasharma
Adding dominickn@ for committer approval, this CL merges changes https://codereview.chromium.org/2938453004 onto M60 3112 branch.
3 years, 6 months ago (2017-06-17 08:44:15 UTC) #3
dominickn
lgtm (don't forget the NOTRY etc.!)
3 years, 6 months ago (2017-06-19 00:15:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949433002/1
3 years, 6 months ago (2017-06-19 01:03:53 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 01:04:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21618e7dc6ce5148fd09bdb6abb3...

Powered by Google App Engine
This is Rietveld 408576698