Implement large cursors in Mushrome.

Implement large cursors in Mushrome.

This transitions a ui enum to an enum class, and adds support for
sending it across mojo pipes. The window manager now has an API to
change which cursor set is used on the window server.

BUG=729798
Review-Url: https://codereview.chromium.org/2949353003
Cr-Commit-Position: refs/heads/master@{#482038}
Committed: https://chromium.googlesource.com/chromium/src/+/c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8

[Elliot Glaysher, 2017-06-22 19:58:44]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 19:58:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 20:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 20:08:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Elliot Glaysher, 2017-06-22 20:21:52]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 20:22:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 20:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 20:50:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-06-22 21:08:27]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 21:08:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-06-22 23:26:09]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 23:26:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-06-22 23:27:15]

erg@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2017-06-22 23:27:17]

sky: review
tsepez: mojom. one more method from the window manager to the window server,
along with an enum transferred between.

[Tom Sepez, 2017-06-23 01:10:48]

https://codereview.chromium.org/2949353003/diff/60001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager.mojom (right):

https://codereview.chromium.org/2949353003/diff/60001/services/ui/public/inte...
services/ui/public/interfaces/window_manager.mojom:323: WmSetCursorSet(CursorSet
cursor_set);
What happens if a bad renderer changes to large (or vice versa) and continues to
use normal cursor methods (or vice versa)?

[commit-bot: I haz the power, 2017-06-23 02:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 02:04:40]

Dry run: This issue passed the CQ dry run.

[sky, 2017-06-23 13:24:26]

LGTM - one comment though. As you went with a rename did you consider
CursorSize? IMO that better conveys what is changing as compared to CursorSet
which suggests a set of cursors not necessarily based on a size.

https://codereview.chromium.org/2949353003/diff/60001/ash/display/cursor_wind...
File ash/display/cursor_window_controller.h (right):

https://codereview.chromium.org/2949353003/diff/60001/ash/display/cursor_wind...
ash/display/cursor_window_controller.h:53: void SetCursorSet(ui::CursorSet);
add cursor_set parameter.

https://codereview.chromium.org/2949353003/diff/60001/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2949353003/diff/60001/services/ui/ws/display....
services/ui/ws/display.h:156: void SetNativeCursorSet(const ui::CursorSet&
cursor_set);
As cursor_set is a enum pass by value.

[Elliot Glaysher, 2017-06-23 19:30:39]

https://codereview.chromium.org/2949353003/diff/60001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager.mojom (right):

https://codereview.chromium.org/2949353003/diff/60001/services/ui/public/inte...
services/ui/public/interfaces/window_manager.mojom:323: WmSetCursorSet(CursorSet
cursor_set);
On 2017/06/23 01:10:48, Tom Sepez wrote:
> What happens if a bad renderer changes to large (or vice versa) and continues
to
> use normal cursor methods (or vice versa)? 

I'm not sure I understand the question. This method is only available to the
window manager.

Let's say you have an untrusted renderer that sets its window's cursor to GRAB.
Mus keeps track of that data and will change the system cursor to GRAB when the
pointer is over that window. But what cursor will it use? A 1x cursor or a 2x?
That's what this method controls.

What happens if the renderer sets the cursor over its window to a small image
when using the large cursor set? It uses the renderer supplied data. This method
just controls selecting the size of inbuilt named cursors.

[Tom Sepez, 2017-06-23 19:34:07]

lgtm

[Elliot Glaysher, 2017-06-23 19:41:10]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 19:41:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-06-23 20:44:44]

renamed everything to CursorSize / cursor_size.

https://codereview.chromium.org/2949353003/diff/60001/ash/display/cursor_wind...
File ash/display/cursor_window_controller.h (right):

https://codereview.chromium.org/2949353003/diff/60001/ash/display/cursor_wind...
ash/display/cursor_window_controller.h:53: void SetCursorSet(ui::CursorSet);
On 2017/06/23 13:24:26, sky wrote:
> add cursor_set parameter.

Done.

https://codereview.chromium.org/2949353003/diff/60001/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2949353003/diff/60001/services/ui/ws/display....
services/ui/ws/display.h:156: void SetNativeCursorSet(const ui::CursorSet&
cursor_set);
On 2017/06/23 13:24:26, sky wrote:
> As cursor_set is a enum pass by value.

Done.

[sky, 2017-06-23 20:49:15]

Awesome! Thanks for the rename. SLGTM

[commit-bot: I haz the power, 2017-06-23 20:49:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 20:49:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-06-23 21:04:25]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2017-06-23 21:04:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2949353003/#ps80001
(title: "rename everything to CursorSize")

[commit-bot: I haz the power, 2017-06-23 21:04:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 21:37:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498251865772230,
"parent_rev": "f71093f87153edd49757b755af6b48cb501ee223", "commit_rev":
"c5323f29ddb3f7fa2f1752c2d9edca50dfd3bde8"}

[commit-bot: I haz the power, 2017-06-23 21:38:06]

Description was changed from

==========
Implement large cursors in Mushrome.

This transitions a ui enum to an enum class, and adds support for
sending it across mojo pipes. The window manager now has an API to
change which cursor set is used on the window server.

BUG=729798
==========

to

==========
Implement large cursors in Mushrome.

This transitions a ui enum to an enum class, and adds support for
sending it across mojo pipes. The window manager now has an API to
change which cursor set is used on the window server.

BUG=729798

Review-Url: https://codereview.chromium.org/2949353003
Cr-Commit-Position: refs/heads/master@{#482038}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5323f29ddb3f7fa2f1752c2d9ed...
==========

[commit-bot: I haz the power, 2017-06-23 21:38:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c5323f29ddb3f7fa2f1752c2d9ed...