Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2949353002: Revert of Show Play Store rating and price in app list (Closed)

Created:
3 years, 6 months ago by fsamuel
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tfarina, srahim+watch_chromium.org, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show Play Store rating and price in app list (patchset #5 id:80001 of https://codereview.chromium.org/2949733002/ ) Reason for revert: Findit reports this is the cause for this: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/88672 Original issue's description: > Show Play Store rating and price in app list > > 1. Provide interfaces in app_list::SearchResult to set price and rating > for instant and play store apps based on specs. > 2. Change the layouts of SearchResultTileItemListView and > SearchResultTileItemView to show price and rating properly based on > specs. > > Specifications: > https://screenshot.googleplex.com/AFQ5HnrMYch > https://screenshot.googleplex.com/0opcNunaJrZ > > The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs > > BUG=734841 > > Review-Url: https://codereview.chromium.org/2949733002 > Cr-Commit-Position: refs/heads/master@{#481618} > Committed: https://chromium.googlesource.com/chromium/src/+/63ddedc4cd3f0a35990b14b618b5415d1a9baeba TBR=hejq@chromium.org,xiyuan@chromium.org,warx@chromium.org,weidongg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=734841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -168 lines) Patch
M ui/app_list/search_result.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ui/app_list/search_result.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/app_list/search_result_observer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_list_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_list_view.cc View 3 chunks +10 lines, -26 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_view.h View 4 chunks +1 line, -14 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_view.cc View 7 chunks +11 lines, -95 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fsamuel
Created Revert of Show Play Store rating and price in app list
3 years, 6 months ago (2017-06-22 19:52:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949353002/1
3 years, 6 months ago (2017-06-22 19:52:52 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-22 19:52:54 UTC) #5
xiyuan
Already reverted in https://codereview.chromium.org/2947313003 :)
3 years, 6 months ago (2017-06-22 19:53:35 UTC) #6
Qiang(Joe) Xu
3 years, 6 months ago (2017-06-22 21:48:20 UTC) #8
Message was sent while issue was closed.
On 2017/06/22 19:53:35, xiyuan wrote:
> Already reverted in https://codereview.chromium.org/2947313003 :)

Close it per above message.

Powered by Google App Engine
This is Rietveld 408576698