Polymer: Stop including test related components to production binary.

Polymer: Stop including test related components to production binary.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2949313002
Cr-Commit-Position: refs/heads/master@{#482334}
Committed: https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad6e7e8339e98b

[dpapad, 2017-06-22 18:16:12]

Description was changed from

==========
Polymer: Stop including test related components to production binary.

BUG=None
==========

to

==========
Polymer: Stop including test related components to production binary.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-22 18:17:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 18:17:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-22 18:32:36]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 18:32:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-22 18:34:40]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-22 19:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 19:25:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2017-06-22 19:53:34]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 19:54:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-22 20:42:39]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 20:43:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 21:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 21:46:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2017-06-22 22:26:01]

@thestig: Do you know how I can include a specific JS file to be evaluated
before .cc
https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc is
executed?

I am moving mock_interactions.js file to not be served via a chrome:// URL
(because it should not be included in prod binary anyway).

[Lei Zhang, 2017-06-22 23:20:22]

On 2017/06/22 22:26:01, dpapad wrote:
> @thestig: Do you know how I can include a specific JS file to be evaluated
> before .cc
> https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc
is
> executed?
> 
> I am moving mock_interactions.js file to not be served via a chrome:// URL
> (because it should not be included in prod binary anyway).

Can you trigger the JS evaluation from C++? Is so, maybe you can do something in
SetUpOnMainThread() ?

[dpapad, 2017-06-23 02:51:01]

On 2017/06/22 at 23:20:22, thestig wrote:
> On 2017/06/22 22:26:01, dpapad wrote:
> > @thestig: Do you know how I can include a specific JS file to be evaluated
> > before .cc
> >
https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc is
> > executed?
> > 
> > I am moving mock_interactions.js file to not be served via a chrome:// URL
> > (because it should not be included in prod binary anyway).
> 
> Can you trigger the JS evaluation from C++? Is so, maybe you can do something
in SetUpOnMainThread() ?

Yes. I am doing basically this in a separate CL
https://codereview.chromium.org/2949883006. Let's see if the bots agree with me
(the tests do pass locally).

[dpapad, 2017-06-23 16:18:48]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 16:19:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-06-23 16:19:16]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-06-23 17:13:22]

lgtm

[commit-bot: I haz the power, 2017-06-23 17:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 17:37:32]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-06-26 17:21:11]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-26 17:21:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 18:38:37]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498497671821570,
"parent_rev": "00d432064a6fcd6252211a938840efb8e36b463f", "commit_rev":
"bfbaeb51e23a640bf32e084e34ad6e7e8339e98b"}

[commit-bot: I haz the power, 2017-06-26 18:38:48]

Description was changed from

==========
Polymer: Stop including test related components to production binary.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Polymer: Stop including test related components to production binary.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2949313002
Cr-Commit-Position: refs/heads/master@{#482334}
Committed:
https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad...
==========

[commit-bot: I haz the power, 2017-06-26 18:38:51]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad...

[dpapad, 2017-06-26 18:56:11]

On 2017/06/26 at 18:38:51, commit-bot wrote:
> Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bfbaeb51e23a640bf32e084e34ad...

This CL should be pointing to crbug.com/734789.