Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2949283002:
[iOS] Set credit card icon using the saved network. (Closed)
Description[iOS] Set credit card icon using the saved network.
When possible, the code stops using the credit card number to obtain the network.
This is because the browser only knows the last four digit or non local cards, which is
not sufficient to know the network.
This CL also changes the label shown for non local credit cards:
Instead of containing "1234", the label contains "Mastercard ... 1234".
BUG=719988
Review-Url: https://codereview.chromium.org/2949283002
Cr-Commit-Position: refs/heads/master@{#482265}
Committed: https://chromium.googlesource.com/chromium/src/+/4e19586ba1c5e3e5c837594366b89cb936928fc9
Patch Set 1 #Patch Set 2 : NetworkAndLastFourDigits #Patch Set 3 : Rebased. #Messages
Total messages: 23 (13 generated)
Description was changed from ========== [iOS] Set credit card icon using the stored network. As opposed to using the stored credit card number, which is not fully available for non local credit cards. BUG=719988 ========== to ========== [iOS] Set credit card icon using the stored network. As opposed to using the stored credit card number, which is not fully available for non local credit cards. BUG=719988 ==========
jif@google.com changed reviewers: + mahmadi@chromium.org
jif@google.com changed reviewers: + jif@google.com
ptal
On 2017/06/22 16:07:04, jif-google wrote: > ptal I tested with my non local card: previously, no icon was shown. With this CL, the correct icon is shown.
lgtm
Forgot to mention, perhaps we can display CreditCard::NetworkAndLastFourDigits instead of the CreditCard::LastFourDigits() for server cards?
Description was changed from ========== [iOS] Set credit card icon using the stored network. As opposed to using the stored credit card number, which is not fully available for non local credit cards. BUG=719988 ========== to ========== [iOS] Set credit card icon using the saved network. When possible, the code stops using the credit card number to obtain the network. This is because the browser only knows the last four digit or non local cards, which is not sufficient to know the network. This CL also changes the label shown for non local credit cards: Instead of containing "1234", the label contains "Mastercard ... 1234". BUG=719988 ==========
jif@google.com changed reviewers: - jif@google.com
jif@chromium.org changed reviewers: + lpromero@chromium.org
+lpromero for OWNER check
lgtm, sorry for the delay!
The CQ bit was checked by lpromero@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mahmadi@chromium.org Link to the patchset: https://codereview.chromium.org/2949283002/#ps20001 (title: "NetworkAndLastFourDigits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jif@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mahmadi@chromium.org, lpromero@chromium.org Link to the patchset: https://codereview.chromium.org/2949283002/#ps40001 (title: "Rebased.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498485673152670,
"parent_rev": "7ed282f8412e8a1b61f2cec36a31dc8d5f820c11", "commit_rev":
"4e19586ba1c5e3e5c837594366b89cb936928fc9"}
Message was sent while issue was closed.
Description was changed from ========== [iOS] Set credit card icon using the saved network. When possible, the code stops using the credit card number to obtain the network. This is because the browser only knows the last four digit or non local cards, which is not sufficient to know the network. This CL also changes the label shown for non local credit cards: Instead of containing "1234", the label contains "Mastercard ... 1234". BUG=719988 ========== to ========== [iOS] Set credit card icon using the saved network. When possible, the code stops using the credit card number to obtain the network. This is because the browser only knows the last four digit or non local cards, which is not sufficient to know the network. This CL also changes the label shown for non local credit cards: Instead of containing "1234", the label contains "Mastercard ... 1234". BUG=719988 Review-Url: https://codereview.chromium.org/2949283002 Cr-Commit-Position: refs/heads/master@{#482265} Committed: https://chromium.googlesource.com/chromium/src/+/4e19586ba1c5e3e5c837594366b8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4e19586ba1c5e3e5c837594366b8... |
