Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2949103008: [ObjC ARC] Converts ios/chrome/browser/native_app_launcher:native_app_launcher to ARC. (Closed)

Created:
3 years, 6 months ago by stkhapugin
Modified:
3 years, 5 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/native_app_launcher:native_app_launcher to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2949103008 Cr-Commit-Position: refs/heads/master@{#482243} Committed: https://chromium.googlesource.com/chromium/src/+/52822b6180a790ba22f56127d0f8af2f3221606f

Patch Set 1 #

Patch Set 2 : missing weak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M ios/chrome/browser/native_app_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/ios_appstore_ids.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm View 4 chunks +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.mm View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stkhapugin
PTAL
3 years, 6 months ago (2017-06-23 16:20:28 UTC) #4
marq (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-23 17:04:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949103008/20001
3 years, 5 months ago (2017-06-26 10:05:47 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 11:32:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/52822b6180a790ba22f56127d0f8...

Powered by Google App Engine
This is Rietveld 408576698