scheduler: more of s/JobID/JobName/ where JobID != Job.JobID.

scheduler/appengine/ui/invocation.go

Index: scheduler/appengine/ui/invocation.go
diff --git a/scheduler/appengine/ui/invocation.go b/scheduler/appengine/ui/invocation.go
index adba3583ebb13e42bc417e7532dfc2f7b517f9d4..a4846fc9ebd83d0d0770ce5263ac74556d02e6ce 100644
--- a/scheduler/appengine/ui/invocation.go
+++ b/scheduler/appengine/ui/invocation.go
@@ -15,6 +15,7 @@ import (
 	"github.com/luci/luci-go/server/templates"
 
 	"github.com/luci/luci-go/scheduler/appengine/engine"
+	"github.com/luci/luci-go/scheduler/appengine/presentation"
 )
 
 func invocationPage(c *router.Context) {
@@ -80,7 +81,7 @@ func handleInvAction(c *router.Context, cb func(string, int64) error) {
 	projectID := c.Params.ByName("ProjectID")
 	jobID := c.Params.ByName("JobID")

[Vadim Sh., 2017/06/21 23:39:09]

JobName here (and in all similar places).

ByName(...) here refers to URL parameters specified r.POST(....).

[tandrii(chromium), 2017/06/22 15:52:55]

oops, indeed I missed these.

 	invID := c.Params.ByName("InvID")
-	if !isJobOwner(c.Context, projectID, jobID) {
+	if !presentation.IsJobOwner(c.Context, projectID, jobID) {
 		http.Error(c.Writer, "Forbidden", 403)
 		return
 	}