scheduler: more of s/JobID/JobName/ where JobID != Job.JobID.

scheduler/appengine/ui/invocation.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package ui
 
 import (
         "fmt"
         "net/http"
         "strconv"
         "sync"
 
         "github.com/luci/luci-go/server/auth"
         "github.com/luci/luci-go/server/router"
         "github.com/luci/luci-go/server/templates"
 
         "github.com/luci/luci-go/scheduler/appengine/engine"
+        "github.com/luci/luci-go/scheduler/appengine/presentation"
 )
 
 func invocationPage(c *router.Context) {
         projectID := c.Params.ByName("ProjectID")
         jobID := c.Params.ByName("JobID")
         invID, err := strconv.ParseInt(c.Params.ByName("InvID"), 10, 64)
         if err != nil {
                 http.Error(c.Writer, "No such invocation", http.StatusNotFound)
                 return
         }
@@ skipping 43 matching lines @@
 
 func abortInvocationAction(c *router.Context) {
         handleInvAction(c, func(jobID string, invID int64) error {
                 who := auth.CurrentIdentity(c.Context)
                 return config(c.Context).Engine.AbortInvocation(c.Context, jobID, invID, who)
         })
 }
 
 func handleInvAction(c *router.Context, cb func(string, int64) error) {
         projectID := c.Params.ByName("ProjectID")
         jobID := c.Params.ByName("JobID")

[Vadim Sh., 2017/06/21 23:39:09]

JobName here (and in all similar places).

ByName(...) here refers to URL parameters specified r.POST(....).

[tandrii(chromium), 2017/06/22 15:52:55]

oops, indeed I missed these.

         invID := c.Params.ByName("InvID")
-        if !isJobOwner(c.Context, projectID, jobID) {
+        if !presentation.IsJobOwner(c.Context, projectID, jobID) {
                 http.Error(c.Writer, "Forbidden", 403)
                 return
         }
         invIDAsInt, err := strconv.ParseInt(invID, 10, 64)
         if err != nil {
                 http.Error(c.Writer, "Bad invocation ID", 400)
                 return
         }
         if err := cb(projectID+"/"+jobID, invIDAsInt); err != nil {
                 panic(err)
         }
         http.Redirect(c.Writer, c.Request, fmt.Sprintf("/jobs/%s/%s/%s", projectID, jobID, invID), http.StatusFound)
 }