Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2949053003: PPC: fixed the 32bit build (Closed)

Created:
3 years, 6 months ago by Anisha.Rohra
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, anisha.rohra, adamk, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: fixed the 32bit build Removed the unnecessary macro. R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2949053003 Cr-Commit-Position: refs/heads/master@{#46142} Committed: https://chromium.googlesource.com/v8/v8/+/ab22e64ebef2c419ca0d3d588b56948a25b747d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Anisha.Rohra
PTAL
3 years, 6 months ago (2017-06-22 13:59:30 UTC) #1
Michael Achenbach
lgtm
3 years, 6 months ago (2017-06-22 14:20:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949053003/1
3 years, 6 months ago (2017-06-22 14:30:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949053003/1
3 years, 6 months ago (2017-06-22 14:31:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/ab22e64ebef2c419ca0d3d588b56948a25b747d0
3 years, 6 months ago (2017-06-22 14:59:40 UTC) #9
Dirk Pranke
3 years, 6 months ago (2017-06-22 15:10:22 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698