chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc - Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons (Closed)

Patch Set: Focus on history.replaceState() Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/typed_urls_helper.cc ('k') | chrome/test/data/favicon/replacestate_with_favicon.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

diff --git a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

index df6506a8507105c24c1f1278de6fa1e0d5e98feb..66a4f336ac88443e841678aab3fd987852317b2b 100644

--- a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

+++ b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

@@ -66,7 +66,7 @@ TEST_F(WebDialogWebContentsDelegateTest, DoNothingMethodsTest) {

EXPECT_TRUE(test_web_contents_delegate_->IsPopupOrPanel(NULL));

history::HistoryAddPageArgs should_add_args(

GURL(), base::Time::Now(), 0, 0, GURL(), history::RedirectList(),

- ui::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false, true);

+ ui::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, base::nullopt, true);

test_web_contents_delegate_->NavigationStateChanged(

NULL, content::InvalidateTypes(0));

test_web_contents_delegate_->ActivateContents(NULL);