chrome/browser/sync/test/integration/typed_urls_helper.cc - Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/typed_urls_helper.cc

Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons (Closed)

Patch Set: Focus on history.replaceState() Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/test/integration/typed_urls_helper.cc

diff --git a/chrome/browser/sync/test/integration/typed_urls_helper.cc b/chrome/browser/sync/test/integration/typed_urls_helper.cc

index 796212ed721f4342632d5489e5d6625e095f25cf..eff97562318c9f61927dc63df4030113fa1039db 100644

--- a/chrome/browser/sync/test/integration/typed_urls_helper.cc

+++ b/chrome/browser/sync/test/integration/typed_urls_helper.cc

@@ -171,7 +171,7 @@ void AddToHistory(history::HistoryService* service,

nullptr, // scope

1234, // nav_entry_id

GURL(), // referrer

- history::RedirectList(), transition, source, false);

+ history::RedirectList(), transition, source, base::nullopt);

}

history::URLRows GetTypedUrlsFromHistoryService(