chrome/browser/search_engines/chrome_template_url_service_client.cc - Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/chrome_template_url_service_client.cc

Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/history_tab_helper.cc ('K') | « chrome/browser/history/history_tab_helper.cc ('k') | chrome/browser/supervised_user/supervised_user_navigation_observer.cc » ('j') | components/history/core/browser/history_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/chrome_template_url_service_client.cc

diff --git a/chrome/browser/search_engines/chrome_template_url_service_client.cc b/chrome/browser/search_engines/chrome_template_url_service_client.cc

index 6653ee6c70a236ce8a5e0598ea359bea5e467670..5ddd45dae970632416da8811132a6b12f4e5e4ce 100644

--- a/chrome/browser/search_engines/chrome_template_url_service_client.cc

+++ b/chrome/browser/search_engines/chrome_template_url_service_client.cc

@@ -60,7 +60,7 @@ void ChromeTemplateURLServiceClient::AddKeywordGeneratedVisit(const GURL& url) {

history_service_->AddPage(url, base::Time::Now(), NULL, 0, GURL(),

history::RedirectList(),

ui::PAGE_TRANSITION_KEYWORD_GENERATED,

- history::SOURCE_BROWSED, false);

+ history::SOURCE_BROWSED, base::nullopt);

}

bool ChromeTemplateURLServiceClient::IsOmniboxExtensionURL(