[WIP] Fix history.replaceState() not propagating back favicons

chrome/browser/history/history_tab_helper.cc

Index: chrome/browser/history/history_tab_helper.cc
diff --git a/chrome/browser/history/history_tab_helper.cc b/chrome/browser/history/history_tab_helper.cc
index ca6c1bd76f0ce6484ca91c23e13fb382f0cb1ae5..66268b0b84052cc15c83a7b0adbfcdba140bd677 100644
--- a/chrome/browser/history/history_tab_helper.cc
+++ b/chrome/browser/history/history_tab_helper.cc
@@ -78,11 +78,16 @@ HistoryTabHelper::CreateHistoryAddPageArgs(
 
   history::HistoryAddPageArgs add_page_args(
       navigation_handle->GetURL(), timestamp,
-      history::ContextIDForWebContents(web_contents()),
-      nav_entry_id, navigation_handle->GetReferrer().url,
+      history::ContextIDForWebContents(web_contents()), nav_entry_id,
+      navigation_handle->GetReferrer().url,
       navigation_handle->GetRedirectChain(),
       navigation_handle->GetPageTransition(), history::SOURCE_BROWSED,
-      navigation_handle->DidReplaceEntry(), consider_for_ntp_most_visited);
+      // TODO / DONOTSUBMIT(mastiz): if we really go with IsSameDocument, the

[sky, 2017/06/22 15:26:39]

?

[mastiz, 2017/06/22 20:31:09]

Sorry scott, the "RFC" in the title was trying to emphasize that this CL is not
in a state to be landed, or even properly reviewed.

I'm looking for guidance and people with expertise in the area of client-side
redirects, including meta-refresh tags and javascript-initiated (reflected in
browser tests). This particular TODO is one of the key questions, as per whether
either of IsSameDocument() or DidReplaceEntry() is appropriate for this purpose.

[Charlie Reis, 2017/06/27 19:10:06]

I think japhet@ is probably the best person to ask about that area, but he's OOO
at the moment.  I'm loosely familiar.

+      // parameters should be renamed.
+      navigation_handle->/*DidReplaceEntry() ?//*/ IsSameDocument()
+          ? base::Optional<GURL>(navigation_handle->GetPreviousURL())
+          : base::nullopt,
+      consider_for_ntp_most_visited);
   if (ui::PageTransitionIsMainFrame(navigation_handle->GetPageTransition()) &&
       virtual_url != navigation_handle->GetURL()) {
     // Hack on the "virtual" URL so that it will appear in history. For some