Implement a skeleton of the Superfish interstitial

components/security_interstitials/core/ssl_error_ui.h

Index: components/security_interstitials/core/ssl_error_ui.h
diff --git a/components/security_interstitials/core/ssl_error_ui.h b/components/security_interstitials/core/ssl_error_ui.h
index d18127bb1a3ec9bd6af95ed357c9d6fcb6d81b9d..23406f963211eb0217cab910b3c7ffa1310bf13d 100644
--- a/components/security_interstitials/core/ssl_error_ui.h
+++ b/components/security_interstitials/core/ssl_error_ui.h
@@ -45,10 +45,15 @@ class SSLErrorUI {
              int display_options,  // Bitmask of SSLErrorOptionsMask values.
              const base::Time& time_triggered,
              ControllerClient* controller);
-  ~SSLErrorUI();
+  virtual ~SSLErrorUI();

[meacer, 2017/06/22 22:35:37]

Interesting, I thought this was already a base class or an interface. Should we
move it to a hierarchy like this?

SSLErrorUI
 - GenericSSLErrorUI
 - SuperfishErrorUI

If someone adds a method to this and forgets to override it in SuperfishErrorUI,
bugs might happen. Not particularly important for this CL though, you can do it
in a separate CL if you choose to do so.

[estark, 2017/06/22 23:17:48]

Sure, I could do that as a follow-up. This is all due to be reworked with the
interstitial refactor, though, so I'm not sure it's worth spending too much time
on.

 
-  void PopulateStringsForHTML(base::DictionaryValue* load_time_data);
-  void HandleCommand(SecurityInterstitialCommands command);
+  virtual void PopulateStringsForHTML(base::DictionaryValue* load_time_data);
+  virtual void HandleCommand(SecurityInterstitialCommands command);
+
+ protected:
+  const net::SSLInfo& ssl_info() const;
+  const base::Time& time_triggered() const;
+  ControllerClient* controller() const;
 
  private:
   void PopulateOverridableStrings(base::DictionaryValue* load_time_data);