Implement a skeleton of the Superfish interstitial

components/security_interstitials/core/ssl_error_ui.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_SSL_ERROR_UI_H_
 #define COMPONENTS_SECURITY_INTERSTITIALS_CORE_SSL_ERROR_UI_H_
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "base/values.h"
@@ skipping 27 matching lines @@
     // decision has expired.
     EXPIRED_BUT_PREVIOUSLY_ALLOWED = 1 << 3,
   };
 
   SSLErrorUI(const GURL& request_url,
              int cert_error,
              const net::SSLInfo& ssl_info,
              int display_options,  // Bitmask of SSLErrorOptionsMask values.
              const base::Time& time_triggered,
              ControllerClient* controller);
-  ~SSLErrorUI();
+  virtual ~SSLErrorUI();

[meacer, 2017/06/22 22:35:37]

Interesting, I thought this was already a base class or an interface. Should we
move it to a hierarchy like this?

SSLErrorUI
 - GenericSSLErrorUI
 - SuperfishErrorUI

If someone adds a method to this and forgets to override it in SuperfishErrorUI,
bugs might happen. Not particularly important for this CL though, you can do it
in a separate CL if you choose to do so.

[estark, 2017/06/22 23:17:48]

Sure, I could do that as a follow-up. This is all due to be reworked with the
interstitial refactor, though, so I'm not sure it's worth spending too much time
on.

 
-  void PopulateStringsForHTML(base::DictionaryValue* load_time_data);
-  void HandleCommand(SecurityInterstitialCommands command);
+  virtual void PopulateStringsForHTML(base::DictionaryValue* load_time_data);
+  virtual void HandleCommand(SecurityInterstitialCommands command);
+
+ protected:
+  const net::SSLInfo& ssl_info() const;
+  const base::Time& time_triggered() const;
+  ControllerClient* controller() const;
 
  private:
   void PopulateOverridableStrings(base::DictionaryValue* load_time_data);
   void PopulateNonOverridableStrings(base::DictionaryValue* load_time_data);
 
   const GURL request_url_;
   const int cert_error_;
   const net::SSLInfo ssl_info_;
   const base::Time time_triggered_;
 
   // Set by the |display_options|.
   const bool requested_strict_enforcement_;
   const bool soft_override_enabled_;  // UI provides a button to dismiss error.
   const bool hard_override_enabled_;  // Dismissing allowed, but no button.
 
   ControllerClient* controller_;
   bool user_made_decision_;  // Whether the user made a choice in the UI.
 
   DISALLOW_COPY_AND_ASSIGN(SSLErrorUI);
 };
 
 }  // security_interstitials
 
 #endif  // COMPONENTS_SECURITY_INTERSTITIALS_CORE_SSL_ERROR_UI_H_