Implement a skeleton of the Superfish interstitial

chrome/browser/ssl/ssl_blocking_page.h

Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index 4a5da75b1b43f8ee862eabb1a3f1e9a7e50b835d..035b51638218559427c4e73d188941861bdbe2a6 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -88,10 +88,17 @@ class SSLBlockingPage
   void PopulateInterstitialStrings(
       base::DictionaryValue* load_time_data) override;
 
- private:
-  SSLBlockingPage(
+ protected:
+  void SetErrorUI(std::unique_ptr<security_interstitials::SSLErrorUI> error_ui);

[meacer, 2017/06/22 19:06:18]

This seems to be called immediately after the constructor in both
SSLBlockingPage and SuperfishBlockingPage. Can we instead pass it to the
constructor directly and keep ssl_error_ui_ as a const member below?

It'll be slightly less error prone to not have a setter, and I think it's easier
to read that way.

[estark, 2017/06/22 22:01:05]

n/a per your later suggestion about getting rid of the separate blocking page
class

+
+  static std::unique_ptr<ChromeMetricsHelper> CreateMetricsHelper(
       content::WebContents* web_contents,
       int cert_error,
+      const GURL& request_url,
+      bool overridable);
+
+  SSLBlockingPage(
+      content::WebContents* web_contents,
       const net::SSLInfo& ssl_info,
       const GURL& request_url,
       int options_mask,
@@ -102,6 +109,7 @@ class SSLBlockingPage
       const base::Callback<void(content::CertificateRequestResultType)>&
           callback);
 
+ private:
   void NotifyDenyCertificate();
 
   base::Callback<void(content::CertificateRequestResultType)> callback_;
@@ -113,7 +121,7 @@ class SSLBlockingPage
   const bool expired_but_previously_allowed_;
 
   const std::unique_ptr<CertReportHelper> cert_report_helper_;
-  const std::unique_ptr<security_interstitials::SSLErrorUI> ssl_error_ui_;
+  std::unique_ptr<security_interstitials::SSLErrorUI> ssl_error_ui_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
 };