Implement a skeleton of the Superfish interstitial

chrome/browser/ssl/ssl_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 70 matching lines @@
   void OverrideEntry(content::NavigationEntry* entry) override;
   void OverrideRendererPrefs(content::RendererPreferences* prefs) override;
   void OnProceed() override;
   void OnDontProceed() override;
 
   // SecurityInterstitialPage implementation:
   bool ShouldCreateNewNavigation() const override;
   void PopulateInterstitialStrings(
       base::DictionaryValue* load_time_data) override;
 
- private:
+ protected:
+  void SetErrorUI(std::unique_ptr<security_interstitials::SSLErrorUI> error_ui);

[meacer, 2017/06/22 19:06:18]

This seems to be called immediately after the constructor in both
SSLBlockingPage and SuperfishBlockingPage. Can we instead pass it to the
constructor directly and keep ssl_error_ui_ as a const member below?

It'll be slightly less error prone to not have a setter, and I think it's easier
to read that way.

[estark, 2017/06/22 22:01:05]

n/a per your later suggestion about getting rid of the separate blocking page
class

+
+  static std::unique_ptr<ChromeMetricsHelper> CreateMetricsHelper(
+      content::WebContents* web_contents,
+      int cert_error,
+      const GURL& request_url,
+      bool overridable);
+
   SSLBlockingPage(
       content::WebContents* web_contents,
-      int cert_error,
       const net::SSLInfo& ssl_info,
       const GURL& request_url,
       int options_mask,
       const base::Time& time_triggered,
       std::unique_ptr<SSLCertReporter> ssl_cert_reporter,
       bool overrideable,
       std::unique_ptr<ChromeMetricsHelper> metrics_helper,
       const base::Callback<void(content::CertificateRequestResultType)>&
           callback);
 
+ private:
   void NotifyDenyCertificate();
 
   base::Callback<void(content::CertificateRequestResultType)> callback_;
   const net::SSLInfo ssl_info_;
   const bool overridable_;  // The UI allows the user to override the error.
 
   // The user previously allowed a bad certificate, but the decision has now
   // expired.
   const bool expired_but_previously_allowed_;
 
   const std::unique_ptr<CertReportHelper> cert_report_helper_;
-  const std::unique_ptr<security_interstitials::SSLErrorUI> ssl_error_ui_;
+  std::unique_ptr<security_interstitials::SSLErrorUI> ssl_error_ui_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_