Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2948963002: Prefer 192x192 icons from Web Manifests instead of 144x144 (Closed)

Created:
3 years, 6 months ago by mastiz
Modified:
3 years, 6 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefer 192x192 icons from Web Manifests instead of 144x144 Fixes an undesirable side effect of https://codereview.chromium.org/2891333002 by overriding the desired size for manifest icons regardless of handler_type_. BUG=735354 Review-Url: https://codereview.chromium.org/2948963002 Cr-Commit-Position: refs/heads/master@{#481854} Committed: https://chromium.googlesource.com/chromium/src/+/059780c6a5531bba2ac89b4ba3278ed6678aa892

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M components/favicon/core/favicon_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/favicon/core/favicon_handler.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mastiz
3 years, 6 months ago (2017-06-21 07:54:19 UTC) #2
pkotwicz
LGTM with nits In my opinion, kNonTouchLargestIconSize == kTouchIconSize on Android. The value can be ...
3 years, 6 months ago (2017-06-21 18:03:43 UTC) #3
mastiz
> In my opinion, kNonTouchLargestIconSize == kTouchIconSize on Android. The value can be different on ...
3 years, 6 months ago (2017-06-23 10:29:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948963002/20001
3 years, 6 months ago (2017-06-23 10:32:51 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 11:51:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/059780c6a5531bba2ac89b4ba327...

Powered by Google App Engine
This is Rietveld 408576698