Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2948953002: MD Bookmarks: Fix spacing in the toast popup when deleting bookmarks (Closed)

Created:
3 years, 6 months ago by tsergeant
Modified:
3 years, 6 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Fix spacing in the toast popup when deleting bookmarks This prevents unnecessary spacing when deleting bookmarks with short names. BUG=733046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2948953002 Cr-Commit-Position: refs/heads/master@{#481454} Committed: https://chromium.googlesource.com/chromium/src/+/66abd3b2a93a32f28727b4cb734cc04ec49d6443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/md_bookmarks/toast_manager.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tsergeant
One-liner! I played around with this, and the major cases still seem to work: - ...
3 years, 6 months ago (2017-06-21 07:50:16 UTC) #5
calamity
lgtm
3 years, 6 months ago (2017-06-22 04:50:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948953002/1
3 years, 6 months ago (2017-06-22 05:42:55 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 05:46:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66abd3b2a93a32f28727b4cb734c...

Powered by Google App Engine
This is Rietveld 408576698