Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2493)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc

Issue 294893005: [SyncFS] Make GetOriginStatusMap asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactoring Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc b/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
index b40cad557e059c9ecac756e7f793eb1eaea45c79..4d8739f9543d62d1e9973a7f1c3e27464e88205a 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
@@ -36,6 +36,11 @@ void EmptyTask(SyncStatusCode status, const SyncStatusCallback& callback) {
FROM_HERE, base::Bind(callback, status));
}
+void SetStatusMap(RemoteFileSyncService::OriginStatusMap* status_map_out,
+ const RemoteFileSyncService::OriginStatusMap& status_map) {
+ *status_map_out = status_map;
+}
+
} // namespace
class MockSyncTask : public ExclusiveTask {
@@ -246,17 +251,18 @@ TEST_F(SyncEngineTest, GetOriginStatusMap) {
GURL origin = extensions::Extension::GetBaseURLFromExtensionId(kAppID);
sync_engine()->RegisterOrigin(GURL("chrome-extension://app_0"),
- CreateResultReceiver(&sync_status));
+ CreateResultReceiver(&sync_status));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SYNC_STATUS_OK, sync_status);
sync_engine()->RegisterOrigin(GURL("chrome-extension://app_1"),
- CreateResultReceiver(&sync_status));
+ CreateResultReceiver(&sync_status));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SYNC_STATUS_OK, sync_status);
RemoteFileSyncService::OriginStatusMap status_map;
- sync_engine()->GetOriginStatusMap(&status_map);
+ sync_engine()->GetOriginStatusMap(base::Bind(&SetStatusMap, &status_map));
tzik 2014/05/21 10:52:33 Does CreateResultReceiver work for this?
peria 2014/05/22 02:25:21 It doesn't work well. No viable conversion is foun
+ base::RunLoop().RunUntilIdle();
ASSERT_EQ(2u, status_map.size());
EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_0")]);
EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_1")]);
@@ -266,7 +272,8 @@ TEST_F(SyncEngineTest, GetOriginStatusMap) {
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SYNC_STATUS_OK, sync_status);
- sync_engine()->GetOriginStatusMap(&status_map);
+ sync_engine()->GetOriginStatusMap(base::Bind(&SetStatusMap, &status_map));
+ base::RunLoop().RunUntilIdle();
ASSERT_EQ(2u, status_map.size());
EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_0")]);
EXPECT_EQ("Disabled", status_map[GURL("chrome-extension://app_1")]);

Powered by Google App Engine
This is Rietveld 408576698