[SyncFS] Make GetOriginStatusMap asynchronous

chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/sync_engine.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/drive/drive_uploader.h"
@@ skipping 18 matching lines @@
 
 namespace {
 
 const char kAppID[] = "app_id";
 
 void EmptyTask(SyncStatusCode status, const SyncStatusCallback& callback) {
   base::MessageLoop::current()->PostTask(
       FROM_HERE, base::Bind(callback, status));
 }
 
+void SetStatusMap(RemoteFileSyncService::OriginStatusMap* status_map_out,
+                  const RemoteFileSyncService::OriginStatusMap& status_map) {
+  *status_map_out = status_map;
+}
+
 }  // namespace
 
 class MockSyncTask : public ExclusiveTask {
  public:
   explicit MockSyncTask(bool used_network) {
     set_used_network(used_network);
   }
   virtual ~MockSyncTask() {}
 
   virtual void RunExclusive(const SyncStatusCallback& callback) OVERRIDE {
@@ skipping 190 matching lines @@
 
   ASSERT_FALSE(metadata_database->FindAppRootTracker("app_2", &tracker));
 }
 
 TEST_F(SyncEngineTest, GetOriginStatusMap) {
   FileTracker tracker;
   SyncStatusCode sync_status = SYNC_STATUS_UNKNOWN;
   GURL origin = extensions::Extension::GetBaseURLFromExtensionId(kAppID);
 
   sync_engine()->RegisterOrigin(GURL("chrome-extension://app_0"),
-                                     CreateResultReceiver(&sync_status));
+                                CreateResultReceiver(&sync_status));
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(SYNC_STATUS_OK, sync_status);
 
   sync_engine()->RegisterOrigin(GURL("chrome-extension://app_1"),
-                                     CreateResultReceiver(&sync_status));
+                                CreateResultReceiver(&sync_status));
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(SYNC_STATUS_OK, sync_status);
 
   RemoteFileSyncService::OriginStatusMap status_map;
-  sync_engine()->GetOriginStatusMap(&status_map);
+  sync_engine()->GetOriginStatusMap(base::Bind(&SetStatusMap, &status_map));

[tzik, 2014/05/21 10:52:33]

Does CreateResultReceiver work for this?

[peria, 2014/05/22 02:25:21]

It doesn't work well.
No viable conversion is found.

+  base::RunLoop().RunUntilIdle();
   ASSERT_EQ(2u, status_map.size());
   EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_0")]);
   EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_1")]);
 
   sync_engine()->DisableOrigin(GURL("chrome-extension://app_1"),
                                CreateResultReceiver(&sync_status));
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(SYNC_STATUS_OK, sync_status);
 
-  sync_engine()->GetOriginStatusMap(&status_map);
+  sync_engine()->GetOriginStatusMap(base::Bind(&SetStatusMap, &status_map));
+  base::RunLoop().RunUntilIdle();
   ASSERT_EQ(2u, status_map.size());
   EXPECT_EQ("Enabled", status_map[GURL("chrome-extension://app_0")]);
   EXPECT_EQ("Disabled", status_map[GURL("chrome-extension://app_1")]);
 }
 
 TEST_F(SyncEngineTest, UpdateServiceState) {
   EXPECT_EQ(REMOTE_SERVICE_OK, sync_engine()->GetCurrentState());
 
   GetSyncEngineTaskManager()->ScheduleTask(
       FROM_HERE,
@@ skipping 92 matching lines @@
       base::Bind(&SyncEngineTest::CheckServiceState,
                  AsWeakPtr(),
                  SYNC_STATUS_OK,
                  REMOTE_SERVICE_OK));
 
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system