[SyncFS] Make GetOriginStatusMap asynchronous

[SyncFS] Make GetOriginStatusMap run asynchronously.


BUG=347425
TEST=./unit_tests --gtest_filter="DriveBackend*:SyncEngine*:Conflict*:RegisterApp*:RemoteTo*:LocalTo*:ListChange*:MetadataDatabase*:TaskDep*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272483

[peria, 2014-05-21 08:22:58]

PTL.
This method seems the last method to be async version.

[tzik, 2014-05-21 10:52:33]

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:264:
sync_engine()->GetOriginStatusMap(base::Bind(&SetStatusMap, &status_map));
Does CreateResultReceiver work for this?

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_unittest.cc
(right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_unittest.cc:297:
base::Bind(&SetStatusMap, &origin_status_map));
ditto

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/remote_file_sync_service.h (right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/remote_file_sync_service.h:119: typedef
base::Callback<void(SyncStatusCode, webkit_blob::ScopedFile)>
please keep these parameter names

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_file_system_service.cc:600:
status_map.insert(*itr);
I think just
status_map.insert(status_map_v2.begin(), status_map_v2.end());
works.

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc
(right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc:90:
base::Unretained(extension_service), callback));
extension_service->AsWeakPtr() and check it in
ConvertExtensionStatusToDictionary? (just in case)

[peria, 2014-05-22 02:25:21]

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:264:
sync_engine()->GetOriginStatusMap(base::Bind(&SetStatusMap, &status_map));
On 2014/05/21 10:52:33, tzik wrote:
> Does CreateResultReceiver work for this?

It doesn't work well.
No viable conversion is found.

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_file_system_service.cc:600:
status_map.insert(*itr);
On 2014/05/21 10:52:33, tzik wrote:
> I think just
> status_map.insert(status_map_v2.begin(), status_map_v2.end());
> works.

Done.

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc
(right):

https://codereview.chromium.org/294893005/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc:90:
base::Unretained(extension_service), callback));
On 2014/05/21 10:52:33, tzik wrote:
> extension_service->AsWeakPtr() and check it in
> ConvertExtensionStatusToDictionary? (just in case)

Done.
There already is a DCHECK(!extension_service).
Should I add other checks (for release builds)?

[tzik, 2014-05-22 03:51:12]

https://codereview.chromium.org/294893005/diff/120001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/remote_file_sync_service.h (right):

https://codereview.chromium.org/294893005/diff/120001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/remote_file_sync_service.h:115:
StatusMapCallback;
# As we chatted locally.
Can we change the parameter type to scoped_ptr<OriginStatusMap>?

[peria, 2014-05-22 04:37:58]

https://codereview.chromium.org/294893005/diff/120001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/remote_file_sync_service.h (right):

https://codereview.chromium.org/294893005/diff/120001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/remote_file_sync_service.h:115:
StatusMapCallback;
On 2014/05/22 03:51:13, tzik wrote:
> # As we chatted locally.
> Can we change the parameter type to scoped_ptr<OriginStatusMap>?

Done.

[tzik, 2014-05-22 05:14:12]

Looks good!

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc
(right):

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc:237:
typedef OriginStatusMap::const_iterator iterator;
ditto

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h
(right):

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h:372:
OriginStatusMap pending_batch_sync_origins_;
Could you revert this?
This is not a OriginStatusMap, a map from origin to a resource_id.

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/sync_file_system_service.cc:591:
base::Passed(status_map.Pass())));
s/status_map.Pass()/&status_map/

[peria, 2014-05-22 06:11:44]

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc
(right):

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc:237:
typedef OriginStatusMap::const_iterator iterator;
On 2014/05/22 05:14:13, tzik wrote:
> ditto

Done.

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h
(right):

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h:372:
OriginStatusMap pending_batch_sync_origins_;
On 2014/05/22 05:14:13, tzik wrote:
> Could you revert this?
> This is not a OriginStatusMap, a map from origin to a resource_id.

Done.

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/294893005/diff/140001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/sync_file_system_service.cc:591:
base::Passed(status_map.Pass())));
On 2014/05/22 05:14:13, tzik wrote:
> s/status_map.Pass()/&status_map/

Done.

[tzik, 2014-05-22 07:26:48]

lgtm

[peria, 2014-05-22 07:36:33]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-22 07:38:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/294893005/160001

[commit-bot: I haz the power, 2014-05-22 13:41:55]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-22 13:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:47:10]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[peria, 2014-05-23 01:24:24]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-23 01:25:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/294893005/180001

[commit-bot: I haz the power, 2014-05-23 03:10:55]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8417)

[commit-bot: I haz the power, 2014-05-23 03:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 03:15:20]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[peria, 2014-05-23 07:16:01]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-05-23 07:18:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/294893005/220001

[commit-bot: I haz the power, 2014-05-23 11:00:09]

Change committed as 272483