Reland "[parser] Forbid \08 in strict strings"

Reland "[parser] Forbid \08 in strict strings"

(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.)

This was never legal; the spec only allows '\0' in strict-mode strings
or templates when not followed by a decimal digit. Previously we were
only enforcing that it not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape
sequences in strings.


BUG=v8:6504
Review-Url: https://codereview.chromium.org/2948903002
Cr-Commit-Position: refs/heads/master@{#46106}
Committed: https://chromium.googlesource.com/v8/v8/+/76078e140a2814930932eb46dc92c4df1eec2394

[bakkot1, 2017-06-21 00:26:03]

Description was changed from

==========
Reland "[parser] Forbid \08 in strict strings"

(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.)

This was never legal; the spec only allows '\0' in strict-mode strings
or templates when not followed by a decimal digit. Previously we were
only enforcing that it not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape
sequences in strings.


BUG=v8:6504
==========

to

==========
Reland "[parser] Forbid \08 in strict strings"

(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.)

This was never legal; the spec only allows '\0' in strict-mode strings
or templates when not followed by a decimal digit. Previously we were
only enforcing that it not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape
sequences in strings.


BUG=v8:6504
==========

[bakkot1, 2017-06-21 00:26:04]

bakkot@gmail.com changed reviewers:
+ vogelheim@chromium.org

[bakkot1, 2017-06-21 00:26:46]

PTAL - just a reland after marking a Chromium test as needing rebaseline.

[vogelheim, 2017-06-21 09:42:19]

lgtm

[bakkot1, 2017-06-21 15:22:08]

The CQ bit was checked by bakkot@gmail.com

[commit-bot: I haz the power, 2017-06-21 15:22:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 17:41:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498058528382990, "parent_rev":
"d9be9fd88d9ee86288c966a4091ef56868e7d5f7", "commit_rev":
"76078e140a2814930932eb46dc92c4df1eec2394"}

[commit-bot: I haz the power, 2017-06-21 17:41:58]

Description was changed from

==========
Reland "[parser] Forbid \08 in strict strings"

(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.)

This was never legal; the spec only allows '\0' in strict-mode strings
or templates when not followed by a decimal digit. Previously we were
only enforcing that it not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape
sequences in strings.


BUG=v8:6504
==========

to

==========
Reland "[parser] Forbid \08 in strict strings"

(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.)

This was never legal; the spec only allows '\0' in strict-mode strings
or templates when not followed by a decimal digit. Previously we were
only enforcing that it not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape
sequences in strings.


BUG=v8:6504

Review-Url: https://codereview.chromium.org/2948903002
Cr-Commit-Position: refs/heads/master@{#46106}
Committed:
https://chromium.googlesource.com/v8/v8/+/76078e140a2814930932eb46dc92c4df1ee...
==========

[commit-bot: I haz the power, 2017-06-21 17:41:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/76078e140a2814930932eb46dc92c4df1ee...