Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2948673002: Revert of [ObjC ARC] Converts ios/web:web to ARC. (Closed)

Created:
3 years, 6 months ago by gchatz
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/web:web to ARC. (patchset #14 id:260001 of https://codereview.chromium.org/2916473002/ ) Reason for revert: Causes SettingsTestCase/testClearCookies to crash with error: FATAL:wk_web_view_configuration_provider.mm(111)] Check failed: !weak_router Original issue's description: > [ObjC ARC] Converts ios/web:web to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Review-Url: https://codereview.chromium.org/2916473002 > Cr-Commit-Position: refs/heads/master@{#480083} > Committed: https://chromium.googlesource.com/chromium/src/+/95903ec2a23312d86a8c26cdcf2721ce8b8f5d66 TBR=stkhapugin@chromium.org,eugenebut@chromium.org,pkl@chromium.org,peterlaurens@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624363 Review-Url: https://codereview.chromium.org/2948673002 Cr-Commit-Position: refs/heads/master@{#480619} Committed: https://chromium.googlesource.com/chromium/src/+/f015772c93c817ecac4adfa27c0b01995bf765cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -173 lines) Patch
M ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/BUILD.gn View 2 chunks +15 lines, -15 lines 0 comments Download
M ios/web/public/web_state/ui/crw_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_web_view_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.h View 1 chunk +5 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.mm View 7 chunks +52 lines, -28 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_content_view.mm View 5 chunks +17 lines, -12 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router.h View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router.mm View 4 chunks +14 lines, -16 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.mm View 3 chunks +4 lines, -8 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 4 chunks +6 lines, -17 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 2 chunks +1 line, -5 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util.mm View 2 chunks +9 lines, -12 lines 0 comments Download
M ios/web/web_state/wk_web_view_security_util.mm View 3 chunks +4 lines, -10 lines 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 2 chunks +30 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
gchatz
Created Revert of [ObjC ARC] Converts ios/web:web to ARC.
3 years, 6 months ago (2017-06-19 21:11:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948673002/1
3 years, 6 months ago (2017-06-19 21:11:32 UTC) #3
PL
On 2017/06/19 21:11:32, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 6 months ago (2017-06-19 21:45:24 UTC) #4
PL
On 2017/06/19 21:45:24, PL wrote: > On 2017/06/19 21:11:32, commit-bot: I haz the power wrote: ...
3 years, 6 months ago (2017-06-19 22:58:55 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 23:05:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f015772c93c817ecac4adfa27c0b...

Powered by Google App Engine
This is Rietveld 408576698