Description was changed from ========== Re-land the "Re-target wheel events only when a new scroll ...
3 years, 6 months ago
(2017-06-19 20:44:20 UTC)
#3
Description was changed from
==========
Re-land the "Re-target wheel events only when a new scroll sequence has
started".
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loops conditions.
BUG=526463
==========
to
==========
Re-land the "Re-target wheel events only when a new scroll sequence has
started".
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
BUG=526463
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago
(2017-06-19 23:34:03 UTC)
#4
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/452852)
3 years, 6 months ago
(2017-06-19 23:34:04 UTC)
#5
On 2017/06/20 15:53:30, bokan wrote: > Also, please keep the subject line in your commit ...
3 years, 6 months ago
(2017-06-20 15:54:33 UTC)
#9
On 2017/06/20 15:53:30, bokan wrote:
> Also, please keep the subject line in your commit on one line, otherwise it'll
> get truncated. [Reland] Re-target wheel events... is fine
If it's too long, I'd reword it to:
[Reland] Re-target wheel events only on new scroll sequence
Or similar
sahel
Description was changed from ========== Re-land the "Re-target wheel events only when a new scroll ...
3 years, 6 months ago
(2017-06-20 15:59:40 UTC)
#10
Description was changed from
==========
Re-land the "Re-target wheel events only when a new scroll sequence has
started".
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
BUG=526463
==========
to
==========
[Reland] Re-target wheel events only on new scroll sequence.
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
BUG=526463
==========
sahel
Patchset #2 (id:20001) has been deleted
3 years, 6 months ago
(2017-06-20 16:20:36 UTC)
#11
Patchset #2 (id:20001) has been deleted
sahel
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-20 16:22:24 UTC)
#12
lgtm (you can TBR the rest since you had the necessary stamps in the other ...
3 years, 6 months ago
(2017-06-20 18:45:16 UTC)
#17
lgtm (you can TBR the rest since you had the necessary stamps in the other patch
and the fix isn't significant)
sahel
Description was changed from ========== [Reland] Re-target wheel events only on new scroll sequence. https://codereview.chromium.org/2928793003 ...
3 years, 6 months ago
(2017-06-20 18:57:20 UTC)
#18
Description was changed from
==========
[Reland] Re-target wheel events only on new scroll sequence.
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
BUG=526463
==========
to
==========
[Reland] Re-target wheel events only on new scroll sequence.
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
TBR=tdresser@chromium.org
BUG=526463
==========
sahel
The CQ bit was checked by sahel@chromium.org
3 years, 6 months ago
(2017-06-20 18:57:31 UTC)
#19
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497985051154500, "parent_rev": "718c9ac88d6bb3d6820c8494c22995c5e9166e25", "commit_rev": "41a6b88b24c4b253939798158f0829144a30f18e"}
3 years, 6 months ago
(2017-06-20 19:03:01 UTC)
#21
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497985051154500,
"parent_rev": "718c9ac88d6bb3d6820c8494c22995c5e9166e25", "commit_rev":
"41a6b88b24c4b253939798158f0829144a30f18e"}
commit-bot: I haz the power
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497985051154500, "parent_rev": "5bc6f18950db69b65a0bc472a0436330d5133533", "commit_rev": "ff468d5a182bd31ea0c1bfa808a3858e213d88cf"}
3 years, 6 months ago
(2017-06-20 19:03:18 UTC)
#22
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497985051154500,
"parent_rev": "5bc6f18950db69b65a0bc472a0436330d5133533", "commit_rev":
"ff468d5a182bd31ea0c1bfa808a3858e213d88cf"}
commit-bot: I haz the power
Description was changed from ========== [Reland] Re-target wheel events only on new scroll sequence. https://codereview.chromium.org/2928793003 ...
3 years, 6 months ago
(2017-06-20 19:03:31 UTC)
#23
Message was sent while issue was closed.
Description was changed from
==========
[Reland] Re-target wheel events only on new scroll sequence.
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
TBR=tdresser@chromium.org
BUG=526463
==========
to
==========
[Reland] Re-target wheel events only on new scroll sequence.
https://codereview.chromium.org/2928793003 is the original cl. The added
browser tests were flaky on Android since device scale factor was not
taken into account in the expected scroll offsets.
This cl adds device scale factor to the expected scroll offsets in while
loop conditions of the added browser tests.
TBR=tdresser@chromium.org
BUG=526463
Review-Url: https://codereview.chromium.org/2948663002
Cr-Commit-Position: refs/heads/master@{#480897}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff468d5a182bd31ea0c1bfa808a3...
==========
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ff468d5a182bd31ea0c1bfa808a3858e213d88cf
3 years, 6 months ago
(2017-06-20 19:03:33 UTC)
#24
Issue 2948663002: [Reland] Re-target wheel events only on new scroll sequence.
(Closed)
Created 3 years, 6 months ago by sahel
Modified 3 years, 6 months ago
Reviewers: bokan
Base URL:
Comments: 2
Chromium Code Reviews
Issue
2948663002:
[Reland] Re-target wheel events only on new scroll sequence. (Closed)
