Cleanup changes related to replacing usage of GetImageScale with GetScaleForScaleFactor

This is in preparation for enabling HiDPI on Windows by default. Most of the changes here are replacing usage of
the ui::GetImageScale function with ui::GetScaleForScaleFactor.

The patch to remove the HiDPI switch and enable it by default will follow. This patch has been incorporated from
girard's patch ( https://codereview.chromium.org/232483005/)

BUG=149881, 362245
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272721

[ananta, 2014-05-20 00:56:05]

Attempt to land girard's patch https://codereview.chromium.org/232483005/
rebased to tip.

[girard, 2014-05-20 05:39:54]

On 2014/05/20 00:56:05, ananta wrote:
> Attempt to land girard's patch https://codereview.chromium.org/232483005/
> rebased to tip.

I've been working through this patch and there are a bunch of unit test
failures. Have you done anything to address this? (I'll update my patch with my
current set of fixes when I get to work in the morning.)

[ananta, 2014-05-20 05:55:38]

On 2014/05/20 05:39:54, girard wrote:
> On 2014/05/20 00:56:05, ananta wrote:
> > Attempt to land girard's patch https://codereview.chromium.org/232483005/
> > rebased to tip.
> 
> I've been working through this patch and there are a bunch of unit test
> failures. Have you done anything to address this? (I'll update my patch with
my
> current set of fixes when I get to work in the morning.)

Sure thing. I was planning to address the failures in an update tomorrow.

Thanks
Ananta

[ananta, 2014-05-22 21:50:06]

Updated the patch with fixes for unit_tests failures seen 
in the previous iteration's try runs.

[cpu_(ooo_6.6-7.5), 2014-05-23 01:10:04]

how about fileicon_source.cc ? does it need to be GetScaleForScaleFactor ?

Other than missing some code like that lgtm.

[ananta, 2014-05-23 01:18:22]

On 2014/05/23 01:10:04, cpu wrote:
> how about fileicon_source.cc ? does it need to be GetScaleForScaleFactor ?
> 
> Other than missing some code like that lgtm.

I think it is related to favicons which need the current display scale. We can
revisit this.
I looked up usages of GetImageScale and we have covered the relevant ones in
this patch.

[girard, 2014-05-23 12:33:58]

On 2014/05/23 01:18:22, ananta wrote:
> On 2014/05/23 01:10:04, cpu wrote:
> > how about fileicon_source.cc ? does it need to be GetScaleForScaleFactor ?
> > 
> > Other than missing some code like that lgtm.
> 
> I think it is related to favicons which need the current display scale. We can
> revisit this.
> I looked up usages of GetImageScale and we have covered the relevant ones in
> this patch.

LGTM

Glad to see this finally landing!

[sky, 2014-05-23 15:49:40]

It looks like this change is both removing the switch and some cleanup
(GetImageScale -> GetScaleFactorForScale). Can you separate these out into two
patches please.

[ananta, 2014-05-23 18:34:40]

On 2014/05/23 15:49:40, sky wrote:
> It looks like this change is both removing the switch and some cleanup
> (GetImageScale -> GetScaleFactorForScale). Can you separate these out into two
> patches please.

Done. PTAL

[sky, 2014-05-23 19:56:48]

LGTM

[ananta, 2014-05-23 21:11:41]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-05-23 21:13:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/294863002/60001

[commit-bot: I haz the power, 2014-05-24 12:44:45]

Change committed as 272721