Enable --high-dpi-support by default.

Enable --high-dpi-support by default.
(Note that this is a registry setting. Also, remove dead references to HiDPI flag.)

BUG=149881, 362245

[girard, 2014-04-14 18:56:09]

Carlos: Here is the patch you requested (enable high dpi by default.) I also
cleaned up some dead code.
Ben: Can you please review as owner?

[cpu_(ooo_6.6-7.5), 2014-04-14 19:55:03]

lgtm with nit

https://codereview.chromium.org/232483005/diff/1/ui/gfx/win/dpi.cc
File ui/gfx/win/dpi.cc (right):

https://codereview.chromium.org/232483005/diff/1/ui/gfx/win/dpi.cc#newcode161
ui/gfx/win/dpi.cc:161: force_highdpi_for_testing = true;
we don't need force_highdpi_for_testing, please remove.

[Ben Goodger (Google), 2014-04-14 21:46:58]

lgtm

[girard, 2014-04-15 00:06:36]

The CQ bit was checked by girard@chromium.org

[commit-bot: I haz the power, 2014-04-15 00:07:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/girard@chromium.org/232483005/20001

[commit-bot: I haz the power, 2014-04-15 01:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 01:14:09]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[girard, 2014-04-22 21:19:33]

Ananta, I've changed the unit tests to call GetScaleForScaleFactor - Can you
please take a look?

[ananta, 2014-04-22 21:41:57]

On 2014/04/22 21:19:33, girard wrote:
> Ananta, I've changed the unit tests to call GetScaleForScaleFactor - Can you
> please take a look?

LGTM

[girard, 2014-04-22 22:14:46]

The CQ bit was checked by girard@chromium.org

[commit-bot: I haz the power, 2014-04-22 22:15:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/girard@chromium.org/232483005/40001

[commit-bot: I haz the power, 2014-04-22 22:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-22 22:15:28]

Failed to apply patch for ui/base/resource/resource_bundle.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/base/resource/resource_bundle.cc
  Hunk #1 FAILED at 632.
  1 out of 1 hunk FAILED -- saving rejects to file
ui/base/resource/resource_bundle.cc.rej

Patch:       ui/base/resource/resource_bundle.cc
Index: ui/base/resource/resource_bundle.cc
diff --git a/ui/base/resource/resource_bundle.cc
b/ui/base/resource/resource_bundle.cc
index
daea33fe880aa4d369efbcb94fe81ff14f96e326..d5b561263b4225292aa0fe83a33ce5048d771480
100644
--- a/ui/base/resource/resource_bundle.cc
+++ b/ui/base/resource/resource_bundle.cc
@@ -632,8 +632,8 @@ void ResourceBundle::AddDataPackFromPathInternal(const
base::FilePath& path,
 void ResourceBundle::AddDataPack(DataPack* data_pack) {
   data_packs_.push_back(data_pack);
 
-  if (GetImageScale(data_pack->GetScaleFactor()) >
-      GetImageScale(max_scale_factor_))
+  if (GetScaleForScaleFactor(data_pack->GetScaleFactor()) >
+    GetScaleForScaleFactor(max_scale_factor_))
     max_scale_factor_ = data_pack->GetScaleFactor();
 }

[girard, 2014-04-23 11:59:05]

The CQ bit was checked by girard@chromium.org

[commit-bot: I haz the power, 2014-04-23 12:00:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/girard@chromium.org/232483005/80001

[commit-bot: I haz the power, 2014-04-23 13:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 13:38:45]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[girard, 2014-05-20 18:31:59]

Ananta: I've disabled a few unit tests - these all deal with multiple resource
loading. Do you think there's a chance of making these work properly?

[ananta, 2014-05-20 21:21:22]

On 2014/05/20 18:31:59, girard wrote:
> Ananta: I've disabled a few unit tests - these all deal with multiple resource
> loading. Do you think there's a chance of making these work properly?
Please hold off on this change for now. I don't think disabling the tests is a
good idea. Some of the failures appear
to be real. We can revisit in a day or two.

Thanks
Ananta

[girard, 2014-05-20 21:57:38]

On 2014/05/20 21:21:22, ananta wrote:
> On 2014/05/20 18:31:59, girard wrote:
> > Ananta: I've disabled a few unit tests - these all deal with multiple
resource
> > loading. Do you think there's a chance of making these work properly?
> Please hold off on this change for now. I don't think disabling the tests is a
> good idea. Some of the failures appear
> to be real. We can revisit in a day or two.
> 
> Thanks
> Ananta

Agreed. Wasn't intending to check in the disabled tests - that was merely a
placeholder so we could figure out how to get them enabled.