Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2948623002: Merge 60: Handle zero timestamp in RTCVideoEncoder timestamp matching & add UMA (Closed)

Created:
3 years, 6 months ago by emircan
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Merge 60: Handle zero timestamp in RTCVideoEncoder timestamp matching & add UMA Desktop/tab capture can send zero as the first frame's capture timestamp. This CL changes treating zero as the default timestamp to handle those cases. If a platform doesn't preserve and return 0 as the timestamp, i.e. Android, the first frame will be matched and calculated correctly. However, second value(which is nonzero) will fail to match and stop. Additionally, this CL adds a UMA to track the platforms and cases where this might fail. BUG=732552 TEST=Observed chrome://webrtc-internals metrics on guado using Hangouts screenshare. Review-Url: https://codereview.chromium.org/2933213003 Cr-Original-Commit-Position: refs/heads/master@{#479097} Review-Url: https://codereview.chromium.org/2948623002 Cr-Commit-Position: refs/branch-heads/3112@{#389} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/16d0a3e701da48ea0e6a1f5b171f6f000bff6993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M content/renderer/media/gpu/rtc_video_encoder.cc View 4 chunks +10 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948623002/1
3 years, 6 months ago (2017-06-19 19:04:33 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 19:35:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16d0a3e701da48ea0e6a1f5b171f...

Powered by Google App Engine
This is Rietveld 408576698