Chromium Code Reviews
DescriptionMerge 60: Handle zero timestamp in RTCVideoEncoder timestamp matching & add UMA
Desktop/tab capture can send zero as the first frame's capture timestamp. This CL
changes treating zero as the default timestamp to handle those cases.
If a platform doesn't preserve and return 0 as the timestamp, i.e. Android, the first
frame will be matched and calculated correctly. However, second value(which is
nonzero) will fail to match and stop.
Additionally, this CL adds a UMA to track the platforms and cases where this might
fail.
BUG=732552
TEST=Observed chrome://webrtc-internals metrics on guado using Hangouts
screenshare.
Review-Url: https://codereview.chromium.org/2933213003
Cr-Original-Commit-Position: refs/heads/master@{#479097}
Review-Url: https://codereview.chromium.org/2948623002
Cr-Commit-Position: refs/branch-heads/3112@{#389}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/16d0a3e701da48ea0e6a1f5b171f6f000bff6993
Patch Set 1 #
Messages
Total messages: 7 (5 generated)
|
||||||||||||||||||||||||||||