[Sync] Get SyncServce instead of ProfileSyncService.

[Sync] Get SyncServce instead of ProfileSyncService.

In unit tests we call SetTestingFactoryAndUse to override how the
ProfileSyncServiceFactory works, and return a SyncService >
FakeSyncService > TestSyncService object. However, in these same unit
tests, we cause the SyncInternalsMessageHandler to call
ProfileSyncServiceFactory::GetForProfile which statically casts to
ProfileSyncService (which extends SyncServiceBase and SyncService),
which is clearly an invalid cast.

This fix switches SyncInternalsMessageHandler's behavior to retrieve
only a SyncService (which is all it uses anyways). It seems that in the
future we may want to auto retrievals from ProfileSyncServiceFactory
and see if we can switch more people to use the SyncService interface
only.

My understanding is that long term everyone external to Sync should
just use SyncService and we will no longer need to expose the concrete
ProfileSyncService, but we are currently very far from that world being
reality.

BUG=731884
Review-Url: https://codereview.chromium.org/2948603002
Cr-Commit-Position: refs/heads/master@{#480831}
Committed: https://chromium.googlesource.com/chromium/src/+/481300507088191e19ebc7f9d722cb58d80cdcdf

[skym, 2017-06-19 18:50:14]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 18:50:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-06-19 18:51:05]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 18:51:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-06-19 18:51:13]

skym@chromium.org changed reviewers:
+ pnoland@chromium.org

[skym, 2017-06-19 18:51:14]

PTAL

[skym, 2017-06-19 18:54:34]

Description was changed from

==========
[Sync] Get SyncServce instead of ProfileSyncService.

BUG=731884
==========

to

==========
[Sync] Get SyncServce instead of ProfileSyncService.

In unit tests we call SetTestingFactoryAndUse to override how the
ProfileSyncServiceFactory works, and return a SyncService >
FakeSyncService > TestSyncService object. However, in these same unit
tests, we cause the SyncInternalsMessageHandler to call
ProfileSyncServiceFactory::GetForProfile which statically casts to
ProfileSyncService (which extends SyncServiceBase and SyncService),
which is clearly an invalid cast.

This fix switches SyncInternalsMessageHandler's behavior to retrieve
only a SyncService (which is all it uses anyways). It seems that in the
future we may want to auto retrievals from ProfileSyncServiceFactory
and see if we can switch more people to use the SyncService interface
only.

My understanding is that long term everyone external to Sync should
just use SyncService and we will no longer need to expose the concrete
ProfileSyncService, but we are currently very far from that world being
reality.

BUG=731884
==========

[commit-bot: I haz the power, 2017-06-19 19:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 19:56:50]

Dry run: This issue passed the CQ dry run.

[Patrick Noland, 2017-06-19 20:51:06]

lgtm

[skym, 2017-06-19 21:10:15]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-06-19 21:10:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 21:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 21:22:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[skym, 2017-06-19 21:24:17]

skym@chromium.org changed reviewers:
+ calamity@chromium.org

[skym, 2017-06-19 21:24:18]

+calamity for chrome/browser/ui/webui/ OWNERS, PTAL

[calamity, 2017-06-20 03:35:29]

sync_internals_message_handler.cc lgtm.

[skym, 2017-06-20 15:43:06]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-06-20 15:43:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 15:48:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497973386208110, "parent_rev":
"aa22fa5e688e165d704990b2e18b9c1f73c2ab4c", "commit_rev":
"481300507088191e19ebc7f9d722cb58d80cdcdf"}

[commit-bot: I haz the power, 2017-06-20 15:48:16]

Description was changed from

==========
[Sync] Get SyncServce instead of ProfileSyncService.

In unit tests we call SetTestingFactoryAndUse to override how the
ProfileSyncServiceFactory works, and return a SyncService >
FakeSyncService > TestSyncService object. However, in these same unit
tests, we cause the SyncInternalsMessageHandler to call
ProfileSyncServiceFactory::GetForProfile which statically casts to
ProfileSyncService (which extends SyncServiceBase and SyncService),
which is clearly an invalid cast.

This fix switches SyncInternalsMessageHandler's behavior to retrieve
only a SyncService (which is all it uses anyways). It seems that in the
future we may want to auto retrievals from ProfileSyncServiceFactory
and see if we can switch more people to use the SyncService interface
only.

My understanding is that long term everyone external to Sync should
just use SyncService and we will no longer need to expose the concrete
ProfileSyncService, but we are currently very far from that world being
reality.

BUG=731884
==========

to

==========
[Sync] Get SyncServce instead of ProfileSyncService.

In unit tests we call SetTestingFactoryAndUse to override how the
ProfileSyncServiceFactory works, and return a SyncService >
FakeSyncService > TestSyncService object. However, in these same unit
tests, we cause the SyncInternalsMessageHandler to call
ProfileSyncServiceFactory::GetForProfile which statically casts to
ProfileSyncService (which extends SyncServiceBase and SyncService),
which is clearly an invalid cast.

This fix switches SyncInternalsMessageHandler's behavior to retrieve
only a SyncService (which is all it uses anyways). It seems that in the
future we may want to auto retrievals from ProfileSyncServiceFactory
and see if we can switch more people to use the SyncService interface
only.

My understanding is that long term everyone external to Sync should
just use SyncService and we will no longer need to expose the concrete
ProfileSyncService, but we are currently very far from that world being
reality.

BUG=731884

Review-Url: https://codereview.chromium.org/2948603002
Cr-Commit-Position: refs/heads/master@{#480831}
Committed:
https://chromium.googlesource.com/chromium/src/+/481300507088191e19ebc7f9d722...
==========

[commit-bot: I haz the power, 2017-06-20 15:48:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/481300507088191e19ebc7f9d722...