Run clang-format on .js files in c/b/r/md_extensions

Run clang-format on .js files in c/b/r/md_extensions

R=rdevlin.cronin@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2948443003
Cr-Commit-Position: refs/heads/master@{#480954}
Committed: https://chromium.googlesource.com/chromium/src/+/fe199f4407a2d90e1cd7d95b072896f17cfd0f97

[Dan Beam, 2017-06-16 22:35:52]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2017-06-16 22:35:53]

Description was changed from

==========
Run clang-format on .js files in c/b/r/md_extensions

R=rdevlin.cronin@chromium.org
BUG=567770
==========

to

==========
Run clang-format on .js files in c/b/r/md_extensions

R=rdevlin.cronin@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-06-16 22:36:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 00:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:19:00]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-17 02:25:40]

There are a few points I don't like, but I'm willing to accept that most of them
are just my opinion, and thus, more or less irrelevant. :)  But there are two
issues that I think might violate google style, which I feel like is a shame. 
Do we either have a) a way to bring these into google style (preferable) or b)
explicit chromium style guidelines expressing an opinion?  I'd prefer we don't
have clang format conflict with what our own style guide tells us to do
(regardless of which we choose, I'd like it to be consistent).

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/code_section.js (right):

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/code_section.js:38:
(!this.code.beforeHighlight && !this.code.highlight &&
this now violates the rectangle rule, which I *thought* was part of our style,
but now only appears briefly (though this style violates that brief rule).

Do you know if a) style preference has changed or b) we can tweak the js format
to respect rectangle-rule style?

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/drop_overlay.js (right):

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/drop_overlay.js:6: 'use strict';
Doesn't this violate indentation rules where functions must be +2?

[Dan Beam, 2017-06-19 23:01:25]

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/code_section.js (right):

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/code_section.js:38:
(!this.code.beforeHighlight && !this.code.highlight &&
On 2017/06/17 02:25:39, Devlin (OOO June 19) wrote:
> this now violates the rectangle rule, which I *thought* was part of our style,
> but now only appears briefly (though this style violates that brief rule).
> 
> Do you know if a) style preference has changed or b) we can tweak the js
format
> to respect rectangle-rule style?

there's an internal reference to this rectangle rule
go/js#formatting-where-to-break but i don't think this new style violates it/

can you explain to me why you think this violates the rectangle rule?  note:
it's not about visually appearing like a rectangle.

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/drop_overlay.js (right):

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/drop_overlay.js:6: 'use strict';
On 2017/06/17 02:25:40, Devlin (OOO June 19) wrote:
> Doesn't this violate indentation rules where functions must be +2?

started a javascript-style@ thread about this

fwiw: I don't think (function() {...})() is used very much in Google-internal JS
code (so it may be less thought about in general)

[Devlin, 2017-06-20 16:02:06]

lgtm.

Those concerns can be resolved async, since the fix would just be a git cl
format away :)

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/code_section.js (right):

https://codereview.chromium.org/2948443003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/code_section.js:38:
(!this.code.beforeHighlight && !this.code.highlight &&
On 2017/06/19 23:01:24, Dan Beam (no longer on Chrome) wrote:
> On 2017/06/17 02:25:39, Devlin (OOO June 19) wrote:
> > this now violates the rectangle rule, which I *thought* was part of our
style,
> > but now only appears briefly (though this style violates that brief rule).
> > 
> > Do you know if a) style preference has changed or b) we can tweak the js
> format
> > to respect rectangle-rule style?
> 
> there's an internal reference to this rectangle rule
> go/js#formatting-where-to-break but i don't think this new style violates it/
> 
> can you explain to me why you think this violates the rectangle rule?  note:
> it's not about visually appearing like a rectangle.

The rule says you should be able to "draw" a rectangle around each "subtree"
(strange phrasing, but it's what it uses).  In this case, you can't draw a
rectangle around the return value (excluding the return statement).

That said, if this is only really described in the internal docs, it doesn't
really apply to chromium, so maybe this is fine?

[Dan Beam, 2017-06-20 19:08:00]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-20 19:08:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 20:50:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497985680094360, "parent_rev":
"3029e8547965ce8f4d09019a54d79c1fe1cb3def", "commit_rev":
"fe199f4407a2d90e1cd7d95b072896f17cfd0f97"}

[commit-bot: I haz the power, 2017-06-20 20:50:16]

Description was changed from

==========
Run clang-format on .js files in c/b/r/md_extensions

R=rdevlin.cronin@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on .js files in c/b/r/md_extensions

R=rdevlin.cronin@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2948443003
Cr-Commit-Position: refs/heads/master@{#480954}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe199f4407a2d90e1cd7d95b0728...
==========

[commit-bot: I haz the power, 2017-06-20 20:50:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe199f4407a2d90e1cd7d95b0728...