[Merge to M60] Change linux default hidden file save directory to XDG_DATA_HOME

[Merge to M60] Change linux default hidden file save directory to XDG_DATA_HOME

> Versions of GTK3 up to 3.14.7 had a bug that would cause a segfault
> when a GtkFileChooser was open and a hidden file in the directory was
> deleted [1].
>
> Chrome can trigger this bug in the following scenario:
> 1. Open 2 windows
> 2. Open a save dialog in each window
> 3. Close one of the dialogs
>
> Chrome saves a file in two stages: it writes the contents to a hidden
> file, and then renames it to the actual file.  This is so the file can
> be downloading as the user is choosing a file to save to.
>
> By default, the hidden file is placed into whichever directory the
> save dialog opens with.  In the case of 2 save dialogs open at once,
> if the user saves the file (renames the hidden file) or cancels the
> download (deletes the hidden file), the GTK bug would be triggered.
>
> This CL changes the default directory for the hidden files to
> XDG_DATA_HOME in an effort to make triggering the GTK bug far less
> likely.
>
> [1] https://mail.gnome.org/archives/commits-list/2014-December/msg02447.html
>
> BUG=728501
> R=thestig@chromium.org
> TBR=qinmin@chromium.org

BUG=728501
TBR=qinmin@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2948443002
Cr-Commit-Position: refs/branch-heads/3112@{#371}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/686705b6198717779f1452d0fda7d50245eb0d0f

[Tom Anderson, 2017-06-16 20:31:37]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-06-16 20:31:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 20:32:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497645097114050, "parent_rev":
"02d8551dfe076a0ed784c8f307a6132fe1fc3c22", "commit_rev":
"e8df2e915a694b1378f98aefd93087b70cbb3455"}

[commit-bot: I haz the power, 2017-06-16 20:32:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497645097114050, "parent_rev":
"02d8551dfe076a0ed784c8f307a6132fe1fc3c22", "commit_rev":
"e8df2e915a694b1378f98aefd93087b70cbb3455"}

[commit-bot: I haz the power, 2017-06-16 20:32:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497645097114050, "parent_rev":
"02d8551dfe076a0ed784c8f307a6132fe1fc3c22", "commit_rev":
"e8df2e915a694b1378f98aefd93087b70cbb3455"}

[commit-bot: I haz the power, 2017-06-16 20:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 20:32:43]

Failed to commit the patch.

[Tom Anderson, 2017-06-16 23:34:21]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-06-16 23:34:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 23:35:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497656061275090, "parent_rev":
"2e193fbb20ab0b9118937a7c82d8e1ce7eaad410", "commit_rev":
"686705b6198717779f1452d0fda7d50245eb0d0f"}

[commit-bot: I haz the power, 2017-06-16 23:35:56]

Description was changed from

==========
[Merge to M60] Change linux default hidden file save directory to XDG_DATA_HOME

> Versions of GTK3 up to 3.14.7 had a bug that would cause a segfault
> when a GtkFileChooser was open and a hidden file in the directory was
> deleted [1].
>
> Chrome can trigger this bug in the following scenario:
> 1. Open 2 windows
> 2. Open a save dialog in each window
> 3. Close one of the dialogs
>
> Chrome saves a file in two stages: it writes the contents to a hidden
> file, and then renames it to the actual file.  This is so the file can
> be downloading as the user is choosing a file to save to.
>
> By default, the hidden file is placed into whichever directory the
> save dialog opens with.  In the case of 2 save dialogs open at once,
> if the user saves the file (renames the hidden file) or cancels the
> download (deletes the hidden file), the GTK bug would be triggered.
>
> This CL changes the default directory for the hidden files to
> XDG_DATA_HOME in an effort to make triggering the GTK bug far less
> likely.
>
> [1] https://mail.gnome.org/archives/commits-list/2014-December/msg02447.html
>
> BUG=728501
> R=thestig@chromium.org
> TBR=qinmin@chromium.org

BUG=728501
TBR=qinmin@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
==========

to

==========
[Merge to M60] Change linux default hidden file save directory to XDG_DATA_HOME

> Versions of GTK3 up to 3.14.7 had a bug that would cause a segfault
> when a GtkFileChooser was open and a hidden file in the directory was
> deleted [1].
>
> Chrome can trigger this bug in the following scenario:
> 1. Open 2 windows
> 2. Open a save dialog in each window
> 3. Close one of the dialogs
>
> Chrome saves a file in two stages: it writes the contents to a hidden
> file, and then renames it to the actual file.  This is so the file can
> be downloading as the user is choosing a file to save to.
>
> By default, the hidden file is placed into whichever directory the
> save dialog opens with.  In the case of 2 save dialogs open at once,
> if the user saves the file (renames the hidden file) or cancels the
> download (deletes the hidden file), the GTK bug would be triggered.
>
> This CL changes the default directory for the hidden files to
> XDG_DATA_HOME in an effort to make triggering the GTK bug far less
> likely.
>
> [1] https://mail.gnome.org/archives/commits-list/2014-December/msg02447.html
>
> BUG=728501
> R=thestig@chromium.org
> TBR=qinmin@chromium.org

BUG=728501
TBR=qinmin@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2948443002
Cr-Commit-Position: refs/branch-heads/3112@{#371}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/686705b6198717779f1452d0fda7...
==========

[commit-bot: I haz the power, 2017-06-16 23:35:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/686705b6198717779f1452d0fda7...