Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/WebKit/Source/config.gni

Issue 2948363004: Fix remove_webcore_debug_symbols to avoid constant building (Closed)
Patch Set: Reduce duplication Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/config.gni
diff --git a/third_party/WebKit/Source/config.gni b/third_party/WebKit/Source/config.gni
index a8030224071820fe2d37a5ef80474f1414928fa5..b5232b278312b99e241b50657ded68ee8904fec0 100644
--- a/third_party/WebKit/Source/config.gni
+++ b/third_party/WebKit/Source/config.gni
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/compiler/compiler.gni")
import("//build/config/ui.gni")
import("//third_party/WebKit/public/public_features.gni")
@@ -64,3 +65,18 @@ if (use_default_render_theme) {
if (blink_logging_always_on) {
feature_defines_list += [ "LOG_DISABLED=0" ]
}
+
+if (remove_webcore_debug_symbols) {
+ if (is_win && symbol_level != 0) {
+ # If we use no_symbols on Windows when symbol_level is not zero then no
+ # PDB will be generated but ninja will be expecting one. This would mean
+ # that the build would always be dirty. Using minimal_symbols in this
+ # situation keeps the build times fast (roughly identical to no_symbols)
+ # while still generating a PDB to keep ninja happy (and it gives us proper
+ # call stacks).
+ remove_webcore_symbols_config =
+ [ "//build/config/compiler:minimal_symbols" ]
+ } else {
+ remove_webcore_symbols_config = [ "//build/config/compiler:no_symbols" ]
+ }
+}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698