Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Side by Side Diff: third_party/WebKit/Source/config.gni

Issue 2948363004: Fix remove_webcore_debug_symbols to avoid constant building (Closed)
Patch Set: Reduce duplication Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/compiler/compiler.gni")
5 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
6 import("//third_party/WebKit/public/public_features.gni") 7 import("//third_party/WebKit/public/public_features.gni")
7 8
8 if (is_android) { 9 if (is_android) {
9 import("//build/config/android/config.gni") 10 import("//build/config/android/config.gni")
10 } 11 }
11 if (current_cpu == "arm") { 12 if (current_cpu == "arm") {
12 import("//build/config/arm.gni") 13 import("//build/config/arm.gni")
13 } 14 }
14 15
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 58
58 if (use_default_render_theme) { 59 if (use_default_render_theme) {
59 # Mirrors the USE_DEFAULT_RENDER_THEME buildflag_header in WebKit/public. 60 # Mirrors the USE_DEFAULT_RENDER_THEME buildflag_header in WebKit/public.
60 # If/when Blink can use buildflag headers, this should be removed in 61 # If/when Blink can use buildflag headers, this should be removed in
61 # preference to that. 62 # preference to that.
62 feature_defines_list += [ "WTF_USE_DEFAULT_RENDER_THEME=1" ] 63 feature_defines_list += [ "WTF_USE_DEFAULT_RENDER_THEME=1" ]
63 } 64 }
64 if (blink_logging_always_on) { 65 if (blink_logging_always_on) {
65 feature_defines_list += [ "LOG_DISABLED=0" ] 66 feature_defines_list += [ "LOG_DISABLED=0" ]
66 } 67 }
68
69 if (remove_webcore_debug_symbols) {
70 if (is_win && symbol_level != 0) {
71 # If we use no_symbols on Windows when symbol_level is not zero then no
72 # PDB will be generated but ninja will be expecting one. This would mean
73 # that the build would always be dirty. Using minimal_symbols in this
74 # situation keeps the build times fast (roughly identical to no_symbols)
75 # while still generating a PDB to keep ninja happy (and it gives us proper
76 # call stacks).
77 remove_webcore_symbols_config =
78 [ "//build/config/compiler:minimal_symbols" ]
79 } else {
80 remove_webcore_symbols_config = [ "//build/config/compiler:no_symbols" ]
81 }
82 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698