Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: mojo/service_manager/service_manager_unittest.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/service_manager/service_manager_unittest.cc
diff --git a/mojo/service_manager/service_manager_unittest.cc b/mojo/service_manager/service_manager_unittest.cc
index 3d21dc80277d28d741e2f6f117726a1c2141cd16..bb103e2adee179bc8911ee1826da0157e6d84985 100644
--- a/mojo/service_manager/service_manager_unittest.cc
+++ b/mojo/service_manager/service_manager_unittest.cc
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "base/message_loop/message_loop.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/public/cpp/environment/environment.h"
#include "mojo/public/cpp/shell/application.h"
#include "mojo/public/interfaces/shell/shell.mojom.h"
@@ -39,7 +38,7 @@ class TestServiceImpl : public InterfaceImpl<TestService> {
}
// TestService implementation:
- virtual void Test(const mojo::String& test_string) OVERRIDE {
+ virtual void Test(mojo::String test_string) OVERRIDE {
context_->last_test_string = test_string.To<std::string>();
client()->AckTest();
}
@@ -64,9 +63,8 @@ class TestClientImpl : public TestClient {
}
void Test(std::string test_string) {
- AllocationScope scope;
quit_after_ack_ = true;
- service_->Test(test_string);
+ service_->Test(String::From(test_string));
}
private:

Powered by Google App Engine
This is Rietveld 408576698