Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: mojo/service_manager/service_manager.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/service_manager/service_manager.cc
diff --git a/mojo/service_manager/service_manager.cc b/mojo/service_manager/service_manager.cc
index 7aa38441fde3977c0396e8b4df22df3c37a3c59f..56800527ac72da630521c0112e3a46f007c908b8 100644
--- a/mojo/service_manager/service_manager.cc
+++ b/mojo/service_manager/service_manager.cc
@@ -10,7 +10,6 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/stl_util.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/service_manager/service_loader.h"
namespace mojo {
@@ -31,16 +30,14 @@ class ServiceManager::ServiceFactory : public InterfaceImpl<Shell> {
}
void ConnectToClient(ScopedMessagePipeHandle handle) {
- if (handle.is_valid()) {
- AllocationScope scope;
- client()->AcceptConnection(url_.spec(), handle.Pass());
- }
+ if (handle.is_valid())
+ client()->AcceptConnection(String::From(url_.spec()), handle.Pass());
}
// Shell implementation:
- virtual void Connect(const String& url,
+ virtual void Connect(String url,
ScopedMessagePipeHandle client_pipe) OVERRIDE {
- manager_->Connect(GURL(url.To<std::string>()), client_pipe.Pass());
+ manager_->Connect(GURL(url), client_pipe.Pass());
}
const GURL& url() const { return url_; }
@@ -67,9 +64,9 @@ class ServiceManager::TestAPI::TestShellConnection
}
// Shell:
- virtual void Connect(const String& url,
+ virtual void Connect(String url,
ScopedMessagePipeHandle client_pipe) OVERRIDE {
- manager_->Connect(GURL(url.To<std::string>()), client_pipe.Pass());
+ manager_->Connect(GURL(url), client_pipe.Pass());
}
private:

Powered by Google App Engine
This is Rietveld 408576698