Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: mojo/service_manager/service_manager_unittest.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/service_manager/service_manager.cc ('k') | mojo/services/dbus_echo/dbus_echo_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/service_manager/service_manager_unittest.cc
diff --git a/mojo/service_manager/service_manager_unittest.cc b/mojo/service_manager/service_manager_unittest.cc
index 0f18cbc60d1124b662b64227551f9da92c0095a2..c3805f31ece10da239c47fe771826643a1f7b9c4 100644
--- a/mojo/service_manager/service_manager_unittest.cc
+++ b/mojo/service_manager/service_manager_unittest.cc
@@ -4,8 +4,6 @@
#include "base/message_loop/message_loop.h"
#include "mojo/public/cpp/application/application.h"
-#include "mojo/public/cpp/application/application.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/public/cpp/environment/environment.h"
#include "mojo/public/interfaces/service_provider/service_provider.mojom.h"
#include "mojo/service_manager/service_loader.h"
@@ -36,8 +34,8 @@ class TestServiceImpl : public InterfaceImpl<TestService> {
}
// TestService implementation:
- virtual void Test(const mojo::String& test_string) OVERRIDE {
- context_->last_test_string = test_string.To<std::string>();
+ virtual void Test(const String& test_string) OVERRIDE {
+ context_->last_test_string = test_string;
client()->AckTest();
}
@@ -61,7 +59,6 @@ class TestClientImpl : public TestClient {
}
void Test(std::string test_string) {
- AllocationScope scope;
quit_after_ack_ = true;
service_->Test(test_string);
}
« no previous file with comments | « mojo/service_manager/service_manager.cc ('k') | mojo/services/dbus_echo/dbus_echo_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698